Closed Bug 735517 Opened 13 years ago Closed 13 years ago

Web Apps icon always appears when other popup notifications appear

Categories

(Firefox Graveyard :: Web Apps, defect)

Product:
Firefox Graveyard
Component:
Web Apps
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox13 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 14
Tracking Flags:
Tracking Status
firefox13 --- verified

People

(Reporter: tetsuharu, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

proposed patch
(deleted), patch
fabrice
: review+
dao
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Enviroment: Windows 7 (x64) http://hg.mozilla.org/mozilla-central/rev/8d1c74566a0b STR: Show popup notification. (e.g. http://maps.google.com/ 's geolocation) Result: Show web app notification icon. This bug is caused by http://hg.mozilla.org/mozilla-central/rev/374977a5f8c6. So the following code is wrong. This element's class attribute should be "notification-anchor-icon". /browser/base/content/browser.xul <image id="webapps-notification-icon" class="webapps-anchor-icon" role="button"/>
Blocks: 697006
Attached file proposed patch (obsolete) (deleted) —
Attached patch proposed patch (deleted) — — Splinter Review
Attachment #605591 - Attachment is obsolete: true
Attachment #605592 - Flags: review+
nice catch!
Keywords: checkin-needed
Keywords: regression
Summary: Show always Web Apps icon when showing popup notification. → Web Apps icon always appears when other popup notifications appear
Attachment #605592 - Flags: review+
Thanks Ohzeki. http://hg.mozilla.org/mozilla-central/rev/629298cfd480
Status: NEW → RESOLVED
Closed: 13 years ago
Component: General → Web Apps
OS: Windows 7 → All
QA Contact: general → webapps
Hardware: x86_64 → All
Resolution: --- → FIXED
Comment on attachment 605592 [details] [diff] [review] proposed patch [Approval Request Comment] This bug is present in Aurora since it landed before the uplift yesterday. Simple patch to fix the webapps icon showing during unrelated popup notifications
Attachment #605592 - Flags: approval-mozilla-aurora?
Comment on attachment 605592 [details] [diff] [review] proposed patch [Triage Comment] Low risk fix in support of webapp notifications. Approved for Aurora 13.
Attachment #605592 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified on Nightly.
Status: RESOLVED → VERIFIED
Also verified on Aurora.
Blocks: 731054
status-firefox13: --- → verified
Target Milestone: --- → Firefox 14
No longer blocks: 731054
Flags: in-moztrap?(jsmith)
QA Contact: jsmith
Flags: in-moztrap?(jsmith) → in-moztrap-
No longer blocks: 735571
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: