Closed
Bug 735536
Opened 13 years ago
Closed 13 years ago
B2G SMS DB: Use new fangled IndexedDB string constants
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: philikon, Assigned: ferjm)
References
Details
(Whiteboard: [good first bug][lang=js][mentor=philikon])
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
See bug 735094.
|
Reporter | |
Comment 1•13 years ago
|
||
Also c.f. bug 735357 for inspiration (not that the fix is that complicated...)
|
|
Reporter | |
Updated•13 years ago
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #606155 -
Flags: review?(philipp)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Sorry, the patch was corrupted and wouldn´t apply.
Attachment #606155 -
Attachment is obsolete: true
Attachment #606155 -
Flags: review?(philipp)
Attachment #606244 -
Flags: review?(philipp)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #606244 -
Attachment is patch: true
|
|
Reporter | |
Comment 5•13 years ago
|
||
Comment on attachment 606244 [details] [diff] [review]
Fix v1
I would actually prefer if we const'ed those values, e.g.:
const READONLY = "readonly";
etc. Looks good otherwise!
Attachment #606244 -
Flags: review?(philipp) → feedback+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Yes, I thought about the constants, but the ContactDB patch didn´t use constants, so I chose to also don´t use it. Anyway, I also prefer this way.
Attachment #606244 -
Attachment is obsolete: true
Attachment #606669 -
Flags: review?(philipp)
|
|
Reporter | |
Updated•13 years ago
|
Attachment #606669 -
Flags: review?(philipp) → review+
|
|
Reporter | |
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•