Closed
Bug 735625
Opened 13 years ago
Closed 13 years ago
Get rid of ImportHTMLFromFileToFolder
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: addon-compat, dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
dietrich
:
review+
Gavin
:
superreview+
|
Details | Diff | Splinter Review |
bug 735312 is removing the last caller, to this method can die.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
Note that I could do much more cleanup than this, since some internal methods have redundant arguments now. Though, since the rewrite from hsivonen is pending review and I already commented on some of those there in my last review pass, it's not worth putting more stuff here. This removal will instead simplify things there, by killing code and clarifying what is left.
Attachment #606038 -
Flags: superreview?(gavin.sharp)
Attachment #606038 -
Flags: review?(dietrich)
Updated•13 years ago
|
Attachment #606038 -
Flags: superreview?(gavin.sharp) → superreview+
Updated•13 years ago
|
Attachment #606038 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 2•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dcabd1aa9c7
Setting addon-compat for the method removal, even if the probability someone uses this is quite low.
Assignee | ||
Comment 3•13 years ago
|
||
and dev-doc-needed in case the interface page needs update
Keywords: dev-doc-needed
Assignee | ||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 5•13 years ago
|
||
Documentation tweaked:
https://developer.mozilla.org/En/Places_Developer_Guide#HTML_Import.2FExport
The interface wasn't documented at all, but now it is, with these changes noted:
https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIPlacesImportExportService
Mentioned on Firefox 14 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•