Closed
Bug 736114
Opened 13 years ago
Closed 13 years ago
B2G Wifi: Fire notification for signal strength changes
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
We need this to put the relative signal strength in the title bar.
Assignee | ||
Comment 1•13 years ago
|
||
Still to do here: - Add an API so that you don't have to wait for an event to update the status (mozWifiManager.connectionInfo, perhaps?). - Suppress the event if nothing changed.
Attachment #607001 -
Flags: feedback?(kaze)
Assignee | ||
Comment 2•13 years ago
|
||
There is now a .connectionInformation property as well as the event. I also avoid sending the event if the signal strength hasn't changed more than 10% since the last time we checked.
Attachment #607001 -
Attachment is obsolete: true
Attachment #607001 -
Flags: feedback?(kaze)
Attachment #607150 -
Flags: review?(gal)
Attachment #607150 -
Flags: feedback?(kaze)
Assignee | ||
Comment 3•13 years ago
|
||
Oh, please pretend that this was applied in the previous diff: diff --git a/dom/wifi/nsIWifi.idl b/dom/wifi/nsIWifi.idl index 8063aac..f06565d 100644 --- a/dom/wifi/nsIWifi.idl +++ b/dom/wifi/nsIWifi.idl @@ -43,7 +43,7 @@ interface nsIWifi : nsISupports { }; -[scriptable, uuid(1509221f-470e-4445-b476-88e74fd5c617)] +[scriptable, uuid(bdc74103-85e7-4e6a-bf68-55fc35b7ad2f)] interface nsIDOMWifiManager : nsISupports { /** * TODO Remove in favor of a settings API.
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 607150 [details] [diff] [review] Patch v1 If this is needed for 2.5, it needs review. Chris might have a little more time at this point than gal.
Attachment #607150 -
Flags: review?(jones.chris.g)
Updated•13 years ago
|
Attachment #607150 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 5•13 years ago
|
||
This is rebased and fixes a couple of dumb bugs in DOMWifiManager.js (notably where I'd switched from this._onConnection... to this._connection...).
Attachment #607150 -
Attachment is obsolete: true
Attachment #607150 -
Flags: review?(gal)
Attachment #607150 -
Flags: feedback?(kaze)
Attachment #609350 -
Flags: review+
Attachment #609350 -
Flags: feedback?(kaze)
Updated•13 years ago
|
Blocks: b2g-wifi
OS: Linux → Gonk
Hardware: x86_64 → ARM
Summary: Wifi: Fire notification for signal strength changes → B2G Wifi: Fire notification for signal strength changes
Assignee | ||
Comment 6•13 years ago
|
||
(slightly tweaked to fix even more typos) https://hg.mozilla.org/mozilla-central/rev/7f4d6e62d1f7
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Assignee | ||
Updated•12 years ago
|
Attachment #609350 -
Flags: feedback?(kaze)
You need to log in
before you can comment on or make changes to this bug.
Description
•