Closed Bug 736707 Opened 13 years ago Closed 13 years ago

B2G SMS: Support type-0 message

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(2 files, 8 obsolete files)

Part 1: TP-PID sanity checks : V5
(deleted), patch
philikon
: review+
Details | Diff | Splinter Review
Part 2: Support Type-0 Message : V5
(deleted), patch
philikon
: review+
Details | Diff | Splinter Review
According to 3GPP 23.040 section 9.2.3.9, "A short message type 0 indicates that the ME must acknowledge receipt of the short message but shall discard its contents."
Blocks: b2g-sms
Whiteboard: [good first bug][lang=js]
Blocks: 736710
There are also three levels of "don't store" throughout the spec and might have to be taken into consideration together. They are: 1) TP-PID: the whole message should be discarded without further handling. 2) DCS MWI(Message Waiting Indication): message should be read and discard after notifying the indication and/or displaying the message content. See bug 736710. 3) In user data header Enhanced Voice Mail Information. See bug 736710. We should focus on 1) in this issue and provide a way that can be reused in related tasks.
Assignee: nobody → vyang
Attached patch Support Type-0 Message (obsolete) (deleted) — — Splinter Review
This change is based on bug 736697, Part 2: Refactor to share methods.
Attachment #607491 - Flags: review?(philipp)
verified with rev 9ff494dfc9b0 ;)
Attached patch Support Type-0 Message : V2 (obsolete) (deleted) — — Splinter Review
1) rebase due to changes in attachment #609252 [details] [diff] [review] 2) now based on bug 736697 part 5
Attachment #607491 - Attachment is obsolete: true
Attachment #607491 - Flags: review?(philipp)
Attachment #609262 - Flags: review?(philipp)
Blocks: 736706
Depends on: 736697
Attached patch Part 1: TP-PID sanity checks (obsolete) (deleted) — — Splinter Review
Attachment #609695 - Flags: review?(philipp)
Attached patch Part 2: Support Type-0 Message : V3 (obsolete) (deleted) — — Splinter Review
rebase due to changes in attachment 609634 [details] [diff] [review] in bug 736697
Attachment #609262 - Attachment is obsolete: true
Attachment #609262 - Flags: review?(philipp)
Attachment #609696 - Flags: review?(philipp)
Attached patch Part 1: TP-PID sanity checks : V2 (obsolete) (deleted) — — Splinter Review
accommodate to changes made in bug 736697 attachment 610085 [details] [diff] [review]
Attachment #609695 - Attachment is obsolete: true
Attachment #609695 - Flags: review?(philipp)
Attachment #610100 - Flags: review?(philipp)
Attached patch Part 1: TP-PID sanity checks : V3 (obsolete) (deleted) — — Splinter Review
upate comments
Attachment #610100 - Attachment is obsolete: true
Attachment #610100 - Flags: review?(philipp)
Attachment #610450 - Flags: review?(philipp)
Attached patch Part 2: Support Type-0 Message : V4 (obsolete) (deleted) — — Splinter Review
update comments
Attachment #609696 - Attachment is obsolete: true
Attachment #609696 - Flags: review?(philipp)
Attachment #610451 - Flags: review?(philipp)
Attached patch Part 1: TP-PID sanity checks : V4 (obsolete) (deleted) — — Splinter Review
missing comma
Attachment #610450 - Attachment is obsolete: true
Attachment #610450 - Flags: review?(philipp)
Attachment #610477 - Flags: review?(philipp)
Comment on attachment 610477 [details] [diff] [review] Part 1: TP-PID sanity checks : V4 Review of attachment 610477 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +3035,5 @@ > + * > + * @return read pid and effective pid. > + * > + * @see 3GPP TS 23.040 9.2.3.9 > + */ Instead of an array return value, could this method simply take the msg object and set msg.epid, msg.pid? I think I would prefer that. r=me with that, unless there's a good reason not do this.
Attachment #610477 - Flags: review?(philipp) → review+
Attachment #610451 - Flags: review?(philipp) → review+
review comment 11
Attachment #610477 - Attachment is obsolete: true
Attachment #612790 - Flags: review?(philipp)
review comment 11
Attachment #610451 - Attachment is obsolete: true
Attachment #612791 - Flags: review?(philipp)
(In reply to Philipp von Weitershausen [:philikon] from comment #11) > Instead of an array return value, could this method simply take the msg > object and set msg.epid, msg.pid? I think I would prefer that. > > r=me with that, unless there's a good reason not do this. I agree. That simplifies the patches. Thanks.
Attachment #612790 - Flags: review?(philipp) → review+
Attachment #612791 - Flags: review?(philipp) → review+
https://hg.mozilla.org/mozilla-central/rev/0d4f1f7d050a https://hg.mozilla.org/mozilla-central/rev/6dffa132f245
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: