Closed
Bug 736763
Opened 13 years ago
Closed 13 years ago
CanSkipInCC when adding roots
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [snappy])
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
When building the graph, we first add a bunch of XPConnect roots. These are checked using CanSkipThis. Then we add things from the purple buffer, which are checked using CanSkipInCC. Any children of these nodes are checked via CanSkipThis. We're already calling CanSkipInCC during graph construction, so hopefully it is safe.
If we check XPConnect roots using CanSkipInCC instead of CanSkipThis, we should be able to remove some more nodes from the graph. This clarifies the role of these two functions a bit: CanSkipInCC is more like CanSkipRoot, and CanSkipThis is more like CanSkipChild.
Assignee | ||
Comment 1•13 years ago
|
||
This passed the try run along with my various other patches I put up for review today. https://tbpl.mozilla.org/?tree=Try&rev=869ed959b506
Assignee: nobody → continuation
Attachment #606889 -
Flags: review?(bugs)
Updated•13 years ago
|
Attachment #606889 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Target Milestone: --- → mozilla14
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [snappy]
You need to log in
before you can comment on or make changes to this bug.
Description
•