Closed
Bug 736883
Opened 13 years ago
Closed 12 years ago
Contacts API: Add pictures
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: gwagner, Assigned: gwagner)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
We want to store pictures in the contacts DB.
|
Assignee | |
Updated•13 years ago
|
Blocks: b2g-contact
|
|
Assignee | |
Updated•13 years ago
|
Summary: Contacts API: Add pictures → Contacts API: Add pictures, messagetone, ringtone
|
|
Assignee | |
Comment 1•13 years ago
|
||
I guess ringtone and messagetone are similar to pictures.
We want ringones and message tones per-contact and not per number right?
How do we want to store them in the DB?
Assignee: nobody → anygregor
|
|
Assignee | |
Comment 2•13 years ago
|
||
The current solution is to put strings into the DB and use the mediastorage API to retrieve the pictures. That should already work.
In order to put pictures in the DB, the framemessagemanager has to be able to transfer blobs.
|
||
Updated•12 years ago
|
blocking-basecamp: --- → +
|
||
Comment 3•12 years ago
|
||
Gregor has confirmed that comment #2 is what we're doing for now and that should be sufficient for Basecamp.
blocking-basecamp: + → ---
|
|
Assignee | |
Updated•12 years ago
|
Summary: Contacts API: Add pictures, messagetone, ringtone → Contacts API: Add pictures
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #648916 -
Flags: review?(bent.mozilla)
Comment on attachment 648916 [details] [diff] [review]
patch
Review of attachment 648916 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/contacts/ContactManager.js
@@ +173,5 @@
> + for (let i = 0; i < aBlob.length; i++) {
> + if (typeof aBlob != 'object') {
> + return null;
> + }
> + if (aBlob[i] instanceof Components.interfaces.nsIDOMBlob) {
Nit: if (!(aBlob[] instanceof ...))
@@ +183,5 @@
> + return aBlob;
> + }
> + return null;
> + };
> +
Nit: whitespace
Attachment #648916 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•