I want us to stop adding stuff directly in jemalloc code, which will allow easier jemalloc upgrades in the future. This bug is about strdup/strndup.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=9363f5544207

Comment on attachment 607179 [details] [diff] [review] Move jemalloc'ed strdup/strndup definitions I have no idea if the build changes are right, but moving the definitions is fine. I don't know if you want to get a review on the build changes from khuey. Could we name the new file something other than jemalloc.c?

(In reply to Justin Lebar [:jlebar] from comment #2) > Could we name the new file something other than jemalloc.c? Any suggestions? I'll probably rename memory/src to memory/build, too.

(In reply to Mike Hommey [:glandium] from comment #3) > (In reply to Justin Lebar [:jlebar] from comment #2) > > Could we name the new file something other than jemalloc.c? > > Any suggestions? extraMallocFuns.c?

Comment on attachment 610108 [details] [diff] [review] Move jemalloc'ed strdup/strndup definitions Review of attachment 610108 [details] [diff] [review]: ----------------------------------------------------------------- ::: Makefile.in @@ +79,5 @@ > endif > > ifdef MOZ_MEMORY > tier_base_dirs += memory/jemalloc > +tier_base_dirs += memory/build Just put these both in one assignment with a continuation. ::: mozglue/build/Makefile.in @@ +48,5 @@ > DIST_INSTALL = 1 > > ifdef MOZ_MEMORY > +SHARED_LIBRARY_LIBS = $(call EXPAND_LIBNAME_PATH,memory,$(DEPTH)/memory/build) > +SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,jemalloc,$(DEPTH)/memory/jemalloc) Single assignment with contuation here too.

(In reply to Ted Mielczarek [:ted] from comment #8) > Comment on attachment 610108 [details] [diff] [review] > Move jemalloc'ed strdup/strndup definitions > > Review of attachment 610108 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: Makefile.in > @@ +79,5 @@ > > endif > > > > ifdef MOZ_MEMORY > > tier_base_dirs += memory/jemalloc > > +tier_base_dirs += memory/build > > Just put these both in one assignment with a continuation. > > ::: mozglue/build/Makefile.in > @@ +48,5 @@ > > DIST_INSTALL = 1 > > > > ifdef MOZ_MEMORY > > +SHARED_LIBRARY_LIBS = $(call EXPAND_LIBNAME_PATH,memory,$(DEPTH)/memory/build) > > +SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,jemalloc,$(DEPTH)/memory/jemalloc) > > Single assignment with contuation here too. I did neither when landing, because in both cases, we're soon going to have ifdef/endif between both lines. https://hg.mozilla.org/integration/mozilla-inbound/rev/c2a9fb626038