Closed
Bug 737029
Opened 13 years ago
Closed 13 years ago
Wifi: Use DOMRequestHelper.jsm in DOMWifiManager.js
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
DOMWifiManager.js and DOMRequestHelper.jsm were written in parallel. DOMWifiManager can lose a few lines by using the request helper.
One thing I noticed is that the request helper doesn't expose a takeRequest-like API (that is getAndRemoveRequest). Fabrice, would you have anything against adding such an API?
|
||
Comment 1•13 years ago
|
||
(In reply to Blake Kaplan (:mrbkap) from comment #0)
> One thing I noticed is that the request helper doesn't expose a
> takeRequest-like API (that is getAndRemoveRequest). Fabrice, would you have
> anything against adding such an API?
Of course not, go ahead!
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Attachment #607574 -
Flags: review?(fabrice) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•