Closed Bug 737337 Opened 13 years ago Closed 13 years ago

Implement lightbox for Marketplace app detail page

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cvan, Assigned: cvan)

References

(
URL
)

Details

We should move over the lightbox JS you did and CSS styles you redid for AMO. FWIW, loading an img with `fragments.js` (for example, with the lightbox gallery on a detail page - http://localhost:8000/en-us/app/seavans-undersea-adventure/) causes binary data to be loaded as the fragment (because the path to the image is /media/img/<filename>.png).
Target Milestone: 6.4.7 → 6.4.8
This is tied to the video stuff, which I'm tackling this week.
Target Milestone: 6.4.8 → 6.4.9
Don't forget the caption associated with screenshots.
Assignee: thepotch → nobody
Blocks: 735054
Priority: -- → P1
Target Milestone: 6.4.9 → 6.5.1
Assignee: nobody → cvan
https://github.com/mozilla/zamboni/commit/a1e5bf7 Implemented for screenshots and videos: https://marketplace-dev.allizom.org/en-US/app/xasdfasdf/
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
There are a bunch of bugs with lightboxes but the lightboxes for the most part, work. I'm calling this implementation bug done.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.