Closed
Bug 737376
Opened 13 years ago
Closed 13 years ago
Wifi: Shut down the wifi workers cleanly
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
cjones found me on IRC today and mentioned that currently B2G doesn't shut down cleanly because during shutdown, workers try to join all of the threads, but wifi has a thread stuck waiting for messages from wpa_supplicant.
Assignee | ||
Comment 1•13 years ago
|
||
Chris, I haven't been able to reproduce the shutdown hang, but this *should* fix it. Can you let me know if this helps?
Comment on attachment 607531 [details] [diff] [review] Possible fix I'll give this a shot, but not confident it'll solve the problem in general.
Assignee | ||
Comment 3•13 years ago
|
||
Oh, I should have mentioned. The shutdown method added to nsIWifi and called here (but seemingly not added in the patch) already existed in WifiWorker.js and it calls WifiManager.setEnabled(false). This has the effect of telling the wpa_supplicant to shut down, unblocking the shutdown process.
Comment on attachment 607531 [details] [diff] [review] Possible fix WFM!
Attachment #607531 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6e9a8454ccae
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•