Closed
Bug 737658
Opened 13 years ago
Closed 6 years ago
Fennec should raise the same key down/press/up event sequence for input forms, regardless of device type or OS version
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect, P3)
Tracking
(firefox28 affected, firefox29 affected, firefox30 affected, firefox31 affected, blocking-fennec1.0 -, fennec+, firefox66 wontfix, firefox67 unaffected, firefox68 unaffected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox28 | --- | affected |
firefox29 | --- | affected |
firefox30 | --- | affected |
firefox31 | --- | affected |
blocking-fennec1.0 | --- | - |
fennec | + | --- |
firefox66 | --- | wontfix |
firefox67 | --- | unaffected |
firefox68 | --- | unaffected |
People
(Reporter: cpeterson, Unassigned)
References
()
Details
(Whiteboard: [webcompat:p2][js])
Attachments
(1 file)
(deleted),
text/html
|
Details |
I am splitting this bug off bug 630576 (which only addresses key events when an input form is not focused).
STR:
1. Load attached testcase web page
2. Tap input focus to the form
3. Type keys
ER:
* Test results for desktop browsers: Firefox, Chrome, and Safari on Mac OS X 10.7:
keydown
keypress
input
keyup
AR:
Fennec's actual results depend on the device:
* Fennec on the Galaxy Nexus:
input
* Fennec on the Samsung S2:
input
input
* Fennec on the Droid Pro:
input
keyup
* Fennec on the Kindle Fire:
input
---
For comparison, here are the test results for other Android browsers:
* Stock browser on the Galaxy Nexus, Galaxy S2, and Droid Pro:
keydown
keypress
input
keyup
* Chrome on the Galaxy Nexus:
keydown
input
keyup
Reporter | ||
Updated•13 years ago
|
blocking-fennec1.0: --- → ?
Updated•13 years ago
|
blocking-fennec1.0: ? → -
Updated•13 years ago
|
tracking-fennec: --- → +
Reporter | ||
Updated•12 years ago
|
Priority: -- → P3
Comment 1•12 years ago
|
||
Confirmed on Huawei Honor (ICS 4.0.3)
* no keyup event in Fennec 14
* keyup in Opera mini/mobile
* keyup in android browser
Reporter | ||
Updated•11 years ago
|
Assignee: cpeterson → nobody
Updated•11 years ago
|
Updated•11 years ago
|
Whiteboard: [mentor=jchen]
I just tested this on Firefox for Android with Google Maps (which uses auto-completion). The search starts only when a space is entered, not with the other letters.
This bug is so annoying, is it hard to fix? @jchen I never dev on Firefox for Android, is it something suitable for a newcomer?
Updated•11 years ago
|
status-firefox28:
--- → affected
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → affected
Assignee | ||
Updated•10 years ago
|
Mentor: nchen
Whiteboard: [mentor=jchen]
Updated•10 years ago
|
Mentor: nchen
Comment 8•10 years ago
|
||
nigelb noticed this on SeatGuru; it totally breaks searching for a plane, which is the whole point of the site. That was Bug 1041669.
This also breaks autocomplete on diaspora*. What can I do to see someone working on this?
Comment 10•9 years ago
|
||
This appears to happen with the Android built in touch screen keyboard on Firefox 39 / Lollipop 5.1.1 / Android Nexus 9
This appears to be ok (onkeydown() is fired) with the same tablet using a bluetooth keyboard.
Comment 11•9 years ago
|
||
This is also happening on Fennec 42.
The codepaths are completely different for IME & batchEdit vs. keyPress
Updated•9 years ago
|
See Also: → https://webcompat.com/issues/2022
Updated•8 years ago
|
Flags: webcompat?
See Also: → https://webcompat.com/issues/6400
Updated•8 years ago
|
Whiteboard: [webcompat] [js]
Updated•8 years ago
|
Flags: webcompat? → webcompat+
Comment 13•7 years ago
|
||
Hm, we have seen some breakage here, including Yahoo and Google properties (I *assume* bug 1145662 is another instance of this), so we should probably have a more careful look at this. Usually, I'd suggest sites to listen to `change` instead, as it is a more reliable solution in general, but folks seem to depend on keyboard events, even on mobile.
Mike, given the potential impact here (and the fact that this has webcompat+ already), do you know someone working on Fenenc's Input/IME at the moment to needinfo here?
Flags: needinfo?(miket)
See Also: → https://webcompat.com/issues/4852
Whiteboard: [webcompat] [js] → [webcompat][js]
Comment 14•7 years ago
|
||
I think Andrew could best redirect the needinfo? (See Comment #13 for more context)
Flags: needinfo?(miket) → needinfo?(overholt)
Comment 15•7 years ago
|
||
Usually I ask Masayuki about these types of things so let's see if he has an opinion on what could/should be done here.
Flags: needinfo?(overholt) → needinfo?(masayuki)
Comment 16•7 years ago
|
||
I'm not so familiar with Android's key event handling (i.e., under widget/android).
According to the symptom, I bet that we need to fix bug 354358 and/or you meet these cases:
https://searchfox.org/mozilla-central/rev/062e1cf551f5bf3f0af33671b818f75a55ac497b/widget/android/GeckoEditableSupport.cpp#601,615
Anyway, jchen may have some ideas.
Flags: needinfo?(masayuki) → needinfo?(nchen)
Comment 17•7 years ago
|
||
If changing "dom.keyboardevent.dispatch_during_composition" to true fixes what you see, only bug 354358 is the cause. I think that making it to true only on Android is fine if it doesn't cause any problem in our UI.
Comment 18•7 years ago
|
||
We do send "dummy" key events for sites that only listen to "keyup"/"keydown"/"keypress" for web compat (see bug 1112212). We turn off this web compat behavior for sites that also listen to "input", with the assumption that the site correctly handles "input" events instead. That booking site does listen to "input", but apparently doesn't handle it correctly, making me think it's a bug on their end.
Flags: needinfo?(nchen)
Comment 19•6 years ago
|
||
Now we are dom.keyboardevent.dispatch_during_composition=true via bug 1137567 etc, do you still have any issue?
As long as I test using Gboard, event type and order are same as Chrome.
Flags: needinfo?(miket)
Comment 20•6 years ago
|
||
Testing on the following:
https://webcompat.com/issues/4852
https://webcompat.com/issues/2022 (same site)
I get expected results (bug if fixed) in Nightly 67, and actual results (bug is visible) in Release 65.
https://webcompat.com/issues/6400 - working now in Nightly 67.
Flags: needinfo?(miket)
Whiteboard: [webcompat][js] → [webcompat:p2][js]
Comment 21•6 years ago
|
||
Firefox 66 beta also works well
Reporter | ||
Comment 22•6 years ago
|
||
I get expected results (bug if fixed) in Nightly 67, and actual results (bug is visible) in Release 65.
Firefox 66 beta also works well
In that case, I'll resolve this bug (seven years after I filed it!) as fixed in 66.
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → wontfix
status-firefox67:
--- → unaffected
status-firefox68:
--- → unaffected
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•