Closed
Bug 737909
Opened 13 years ago
Closed 13 years ago
Fix opt -Werror build with clang
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
The cairo codebase has no general way to mark a place as unreachable (like MOZ_NOT_REACHED), so I just used a known noreturn function that exits on opt builds too (abort).
Attachment #607997 -
Flags: review?(jmuizelaar)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 607997 [details] [diff] [review]
Use abort() instead of assert(0)
I'd rather us just not build cairo with -Werror. Is that possible?
|
Assignee | |
Comment 2•13 years ago
|
||
Turns out that the problem is not a general -Werror, but -Werror=return-type. The bad news is that we don't have support for building just cairo without it. The good news is that it is easier to avoid. The attached patch just adds a dummy return.
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #608063 -
Attachment is obsolete: true
Attachment #608063 -
Flags: review?(jmuizelaar)
Attachment #608065 -
Flags: review?(jmuizelaar)
|
||
Comment 4•13 years ago
|
||
Can we get this on mc please?
|
||
Comment 5•13 years ago
|
||
Comment on attachment 608065 [details] [diff] [review]
alternative patch
Return kPrivateCGCompositeClear instead.
We also need to add a patch to gfx/cairo/
Attachment #608065 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5203c29c114a
https://hg.mozilla.org/mozilla-central/rev/da235c17d8a8
https://hg.mozilla.org/mozilla-central/rev/11ffc371ff2e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
|
|
||
Updated•13 years ago
|
Attachment #607997 -
Flags: review?(jmuizelaar)
You need to log in
before you can comment on or make changes to this bug.
Description
•