Closed Bug 738063 Opened 13 years ago Closed 13 years ago

B2G Wifi: Consolidate ctypes-related worker code

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file, 1 obsolete file)

There's a little bit of code duplication between the Wifi code and the workers in dom/system/gonk. This is a first attempt at consolidating some of this. More can be done later.
Attached patch v1 (obsolete) (deleted) — Splinter Review
* Rename "network_worker.js" to "wifi_worker.js" to avoid confusion with the Network Manager's worker ("net_worker.js" in dom/system/gonk). * Reuse the libnetutils ctypes wrapper from systemlibs.js * Inline libcutils ctypes wrapper for now. systemlibs provides a Javascript-y interface to those functions, so eventually we should consolidate this, but we can leave for a later time. Same with consolidating libhardware_legacy.js and systemlibs.js. Small patches ftw, etc.
Attachment #608119 - Flags: review?(mrbkap)
Attachment #608119 - Flags: review?(mrbkap) → review+
Comment on attachment 608119 [details] [diff] [review] v1 Thx for the review. I should've said that I was going away for a few days so that somebody else could've landed it. Bug 739115 obsoleted this patch now. I'll produce a new one.
Attachment #608119 - Attachment is obsolete: true
Attached patch v2 (deleted) — Splinter Review
Ported the bug 739115 goodness to systemlibs.js, obsoleting libnetutils.js once more. Rest of the patch is the same which was already r+'ed, so I'm going to have cjones rubberstamp this one since he wrote the fix for bug 739115.
Attachment #610744 - Flags: review?(jones.chris.g)
Comment on attachment 610744 [details] [diff] [review] v2 Nice JS garbage fix in stringToIp.
Attachment #610744 - Flags: review?(jones.chris.g) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: