Closed
Bug 738063
Opened 13 years ago
Closed 13 years ago
B2G Wifi: Consolidate ctypes-related worker code
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
There's a little bit of code duplication between the Wifi code and the workers in dom/system/gonk. This is a first attempt at consolidating some of this. More can be done later.
Assignee | ||
Comment 1•13 years ago
|
||
* Rename "network_worker.js" to "wifi_worker.js" to avoid confusion with the Network Manager's worker ("net_worker.js" in dom/system/gonk).
* Reuse the libnetutils ctypes wrapper from systemlibs.js
* Inline libcutils ctypes wrapper for now. systemlibs provides a Javascript-y interface to those functions, so eventually we should consolidate this, but we can leave for a later time. Same with consolidating libhardware_legacy.js and systemlibs.js. Small patches ftw, etc.
Attachment #608119 -
Flags: review?(mrbkap)
Updated•13 years ago
|
Attachment #608119 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 608119 [details] [diff] [review]
v1
Thx for the review. I should've said that I was going away for a few days so that somebody else could've landed it. Bug 739115 obsoleted this patch now. I'll produce a new one.
Attachment #608119 -
Attachment is obsolete: true
Assignee | ||
Comment 3•13 years ago
|
||
Ported the bug 739115 goodness to systemlibs.js, obsoleting libnetutils.js once more. Rest of the patch is the same which was already r+'ed, so I'm going to have cjones rubberstamp this one since he wrote the fix for bug 739115.
Attachment #610744 -
Flags: review?(jones.chris.g)
Comment on attachment 610744 [details] [diff] [review]
v2
Nice JS garbage fix in stringToIp.
Attachment #610744 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•