Closed
Bug 738097
Opened 13 years ago
Closed 13 years ago
"allowclickthrough" used on scrollbars where "clickthrough" was intended
Categories
(Toolkit :: XUL Widgets, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Patch part 6 of bug 392188 landed using the wrong attribute in scrollbar.xml (http://hg.mozilla.org/mozilla-central/rev/f1cd1c78ebd3) - allowclickthrough vs. clickthrough.
Does this mean that part of bug 404267 was not fixed? Or was that change not necessary?
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #608170 -
Flags: review?(mstange)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 608170 [details] [diff] [review]
patch
Good catch! It means that scrollbars in trees weren't clickable / draggable in inactive windows, since trees have clickthrough="never" and scrollbars failed to override clickthrough on themselves. (The right behavior is that scrollbars should always be clickable / draggable on background windows, regardless of whether they're in a clickthrough container.)
Scrollbars in normal (non-tree) scrollboxes correctly have clickthrough="always" set on them by nsGfxScrollFrame.cpp.
Attachment #608170 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → gavin.sharp
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → mozilla14
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•