Boris Zbarsky [:bzbarsky] Assignee
	Description • 13 years ago

I want this for bug 726949.

	Jason Orendorff [:jorendorff]
	Comment 2 • 13 years ago

Comment on attachment 608590 [details] [diff] [review]
Add JSAPI for doing the equivalent of Function.prototype.bind.

Looks good.

Please change the functions JS_BindCallable and js_fun_bind to have return type JSObject * rather than an out parameter.

Can we have a jsapi-test? See js/src/jsapi-tests/README.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 3 • 13 years ago

> Please change the functions JS_BindCallable and js_fun_bind to have return type 
> JSObject* rather than an out parameter.

And use an out param boolean to communicate failure state?  That seems odd for the JS engine...

> Can we have a jsapi-test?

Probably, once I have time to work on this again.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 4 • 13 years ago

Per irc comments, just use NULL return to indicate failure.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 6 • 13 years ago

http://hg.mozilla.org/mozilla-central/rev/f381c497e47a with JSAPI test.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 7 • 13 years ago

Er, https://hg.mozilla.org/integration/mozilla-inbound/rev/f381c497e47a

	Matt Brubeck (:mbrubeck)
	Comment 8 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/f381c497e47a