Open
Bug 738571
Opened 13 years ago
Updated 2 years ago
factor out "Control the default heap size" Makefile snippet
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: myk, Unassigned)
References
Details
This code to control the default heap size appears in four Makefiles already (/xulrunner/app/, /embedding/tests/winEmbed/, /ipc/app/, and /browser/app/), and we're adding it to a fifth over in bug 725408:
ifeq ($(OS_ARCH),WINNT)
#
# Control the default heap size.
# This is the heap returned by GetProcessHeap().
# As we use the CRT heap, the default size is too large and wastes VM.
#
# The default heap size is 1MB on Win32.
# The heap will grow if need be.
#
# Set it to 256k. See bug 127069.
#
ifndef GNU_CC
LDFLAGS += /HEAP:0x40000
ifeq ($(OS_TEST),x86_64)
# set stack to 2MB on x64 build. See bug 582910
LDFLAGS += -STACK:2097152
endif
endif
endif
We should factor it out to a common Makefile snippet.
Comment 1•13 years ago
|
||
We could probably just stick this in rules.mk in the default LDFLAGS for linking an executable.
Comment 2•13 years ago
|
||
config.mk would be a better place imho
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•