Closed
Bug 738601
Opened 13 years ago
Closed 13 years ago
JavaScript strict warnings in utilityOverlay.js
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.11
People
(Reporter: neil, Assigned: sgautherie)
References
Details
Attachments
(1 file)
Warning: function goClickThrobber does not always return a value
Source File: chrome://communicator/content/utilityOverlay.js
Line: 579
Nobody calling goClickThrobber wants a return value so we shouldn't return it.
Warning: variable url redeclares argument
Source File: chrome://communicator/content/utilityOverlay.js
Line: 599, Column: 8
Source Code:
var url = uriFixup.createFixupURI(url, nsIURIFixup.FIXUP_FLAG_NONE);
This only works because var doesn't actually create a new variable, so both uses of url refer to the argument. The new variable should be renamed to uri.
|
Reporter | |
Updated•13 years ago
|
Keywords: helpwanted
Whiteboard: [mentor=Neil][lang=js]
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite-
Keywords: helpwanted
Whiteboard: [mentor=Neil][lang=js]
Target Milestone: --- → seamonkey2.11
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 608945 [details] [diff] [review]
(Av1) utilityOverlay.js: Fix JavaScript strict warnings in goClickThrobber() and isRestricted()
[Checked in: Comment 3]
>- var url =
>+ let uri =
s/let/var/ please.
Attachment #608945 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 608945 [details] [diff] [review]
(Av1) utilityOverlay.js: Fix JavaScript strict warnings in goClickThrobber() and isRestricted()
[Checked in: Comment 3]
http://hg.mozilla.org/comm-central/rev/5f6f8317ac21
Attachment #608945 -
Attachment description: (Av1) utilityOverlay.js: Fix JavaScript strict warnings in goClickThrobber() and isRestricted() → (Av1) utilityOverlay.js: Fix JavaScript strict warnings in goClickThrobber() and isRestricted()
[Checked in: Comment 3]
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•