Build: Firefox 14.0a1 (2012-03-23) Device: LG Optimus 2X (Android 2.2) Steps to reproduce: 1. set up sync 2. go to Android settings > Accounts & sync > Firefox Sync 3. tap on Pair a device Expected results: - "Pair a device" screen should appear and you should be able to introduce the j-pack code from the other device Actual result: - nothing happens, it doesn't take you to the pair a device screen and there are no errors in log. Note: - this is happening only on the LG

Log, please.

triage: p1 assuming a log comes back

I'm not able to reproduce it anymore, maybe it was an environment problem. I'll close this bug as worksforme and I'll reopen if I see it again.

I found out that this is reproducible at the second time. So if you pair a device for the first time it works but after that if you tap on Pair a device for a second device it appears what you can see in the log and nothing happens. This is reproducible for any device.

nom for fennec triage. I'm leaning on release+, since this only happens after pairing a second device, not the first.

tony, do you mean pairing a 'third' device? not second? The first pairing by definition is pairing a second device. Mobile drivers passed on this for today's triage but wishes to discuss it at tomorrow's.

Right, i meant pairing the 3rd device. Tapping the "Pair a device button" does nothing. Attaching my logcat. Galaxy Nexus, 4-10-2012 nightly. 04-10 22:39:10.071: INFO/SyncAdapter(7562): Setting minimum next sync time to 1334123050078 04-10 22:39:10.103: DEBUG/class ch.boye.httpclientandroidlib.impl.conn.tsccm.ThreadSafeClientConnManager(7562): Closing expired connections 04-10 22:39:10.103: DEBUG/class ch.boye.httpclientandroidlib.impl.conn.tsccm.ConnPoolByRoute(7562): Closing expired connections 04-10 22:39:10.103: DEBUG/class ch.boye.httpclientandroidlib.impl.conn.tsccm.ThreadSafeClientConnManager(7562): Shutting down 04-10 22:39:10.110: DEBUG/class ch.boye.httpclientandroidlib.impl.conn.DefaultClientConnection(7562): Connection closed 04-10 22:39:10.110: DEBUG/class ch.boye.httpclientandroidlib.impl.conn.DefaultClientConnection(7562): Connection closed 04-10 22:39:10.150: INFO/SyncAdapter(7562): Not syncing: must wait another 299915ms. 04-10 22:39:20.837: INFO/ActivityManager(206): START {act=android.settings.SYNC_SETTINGS flg=0x30000 cmp=com.android.settings/.Settings$ManageAccountsSettingsActivity} from pid 7562 04-10 22:39:21.040: DEBUG/dalvikvm(8377): GC_CONCURRENT freed 68K, 2% free 15428K/15623K, paused 4ms+3ms 04-10 22:39:21.056: INFO/WindowManager(206): createSurface Window{41dbfae0 com.android.settings/com.android.settings.Settings$ManageAccountsSettingsActivity paused=false}: DRAW NOW PENDING 04-10 22:39:21.454: INFO/ActivityManager(206): Displayed com.android.settings/.Settings$ManageAccountsSettingsActivity: +566ms 04-10 22:40:08.532: WARN/ThrottleService(206): unable to find stats for iface rmnet0 04-10 22:40:24.267: INFO/ActivityManager(206): No longer want com.google.android.partnersetup (pid 8180): hidden #16 04-10 22:40:24.376: INFO/ActivityManager(206): START {act=android.intent.action.MAIN cmp=com.android.settings/.SubSettings (has extras)} from pid 8377 04-10 22:40:24.556: INFO/WindowManager(206): createSurface Window{41e44438 com.android.settings/com.android.settings.SubSettings paused=false}: DRAW NOW PENDING 04-10 22:40:24.782: DEBUG/OpenGLRenderer(8377): Flushing caches (mode 0) 04-10 22:40:24.978: INFO/ActivityManager(206): Displayed com.android.settings/.SubSettings: +532ms 04-10 22:40:32.595: INFO/ActivityManager(206): START {act=android.intent.action.MAIN flg=0x10000000 cmp=org.mozilla.fennec/org.mozilla.gecko.sync.setup.activities.SetupSyncActivity (has extras)} from pid 8377 04-10 22:40:35.501: INFO/ActivityManager(206): START {act=android.intent.action.MAIN flg=0x10000000 cmp=org.mozilla.fennec/org.mozilla.gecko.sync.setup.activities.SetupSyncActivity (has extras)} from pid 8377 04-10 22:40:47.642: INFO/ActivityManager(206): START {act=android.intent.action.MAIN flg=0x10000000 cmp=org.mozilla.fennec/org.mozilla.gecko.sync.setup.activities.SetupSyncActivity (has extras)} from pid 8377

tl;dr: cannot reproduce on Transformer Prime with m-i and develop pulled today. - With account already set-up, I go to - Settings > Accounts & Sync > nalexander+test0416@mozilla.com > Pair a Device - screen says 'Select "Pair a Device" in the Sync section of your desktop Firefox options.' - does not show code to enter - does not bring up keyboard automatically, but is focused (Bug 742111) - (should not auto-complete)! - on fresh desktop, "Pair a Device" expects a code from the device! - "Set Up Firefox Sync" > I have an account - provides the code to enter on the device - which correctly configures the desktop I paired multiple fresh desktop profiles this way with no problems. I tried to do this on an Android r8 (2.2) emulator but Fennec no longer works (Maple/libmozglue issues). I did see the following strict mode warnings, but I have no reason to think they are causing the issues. E StrictMode(2834) class org.mozilla.gecko.sync.setup.activities.SetupSyncActivity; instances=2; limit=1 E StrictMode(2834) android.os.StrictMode$InstanceCountViolation: class org.mozilla.gecko.sync.setup.activities.SetupSyncActivity; instances=2; limit=1 E StrictMode(2834) at android.os.StrictMode.setClassInstanceLimit(StrictMode.java:1)

reopening. this still doesnt work. 04-23-2012 build, HTC Incredible S. Follow the same steps and try to pair a 3rd device. Tapping the Pair a device button results in no activity. Logcat shows a measly output of: 04-23 22:02:48.960: WARN/AccountManagerService(1491): calling uid equals android.os.Process.SYSTEM_UID, ignore check hasAuthenticatorUid() 04-23 22:02:48.960: INFO/ActivityManager(1491): Starting activity: Intent { act=android.intent.action.MAIN flg=0x10000000 cmp=org.mozilla.fennec/org.mozilla.gecko.sync.setup.activities.SetupSyncActivity (has extras) } from pid 10732

… and just because this bites a lot: you have only one Fennec installed?

(In reply to Richard Newman [:rnewman] from comment #12) > … and just because this bites a lot: you have only one Fennec installed? yes, one fennec only. learned from that mistake :)

Back over to Chenxia!

Clearing target milestone so that this doesn't look deceiving.

OK, here's the problem. When pairing succeeds, we show the success activity. This is dumb, because it says "Your Firefox Sync account is already set up; you can manage it in Settings", or something like that. If you tap Settings on that screen, you get the main Account settings window. You tap your Firefox Sync account, and tap Pair, and nothing happens. That's because the stack is now like this: Fennec Settings Sync account Pair Settings Sync account and we won't move Pair to the front. If, after your first pairing, you hit BACK, not Settings, you end up here: Fennec Settings Sync account which is just like the first run through, and you can tap Pair again and all is well. Chenxia, that should be enough for you to work with. I don't know if we want to move the pairing screen to the front and refresh it, or change the success screen for pairing to not be crazy, but we should do something.

After testing on my device, I think killing the success screen won't work, because the problem is slightly different - still activity ordering problems, though. After pairing an additional device from Sync settings, you end up with two settings activities, right next to each other, so your stack is: Fennec Settings Settings (The other activities finish() themselves. When hitting back, I don't see them in the stack at all.) The problem (as repro-d on my device) seems to be having two Settings activities, both trying to start the Pair activity - if you hit back so the stack contains only one Settings, that is [Fennec, Settings], you can pair additionally devices as expected. So, I'm not sure why this is, but it seems like intents to start Pair only succeed from one Settings instance. Another problem is that this seems to be pretty device specific. Pairing succeeds on the Asus Transformer if onResume() is called from onNewIntent. On tchung's device, killing all Settings activities manually did not cause pairing to start working again.

looks good with try build. I was able to add a third device to account by entering jpake code on mobile.

Thanks, Tracy.

This has been on m-c for a while now. Soft blocker, but small change.

Sync team. No rush for uplift. This can wait for the next betaN

Comment on attachment 623478 [details] [diff] [review] Patch for uplift. [Triage Comment] Approved for Aurora 14 in support of re-pairing.

Verified fix on nightly and beta 2