Commercial build: Win32 2001-03-28-09-Mtrunk STEPS: 1- Using N6Setup.exe, select a proxy when installing. 2- Complete successful install. 3- Examine all-proxy.js The file seems to have a set of prefs entries for each previous install, almost like a log. Bug 39015 describes the basic function of this feature, and from the reading, my feeling is that the installer should over-write, rather than append an existing all-proxy.js.

but does it pick up the last settings set? The installer does not have a parser to search/replace strings in a file. What happens if you run and quit mozilla.exe? do you still see multiple settings, or just one?

I've been told that the prefs loader keeps only the last value for duplicate lines. If all-proxy.js exists, then blow it away before writing the new values.

over to david.

taking all proxy related bugs

adding Ben to proxy bugs as requested

Another example of some serious bustage: While goofing around and installing mozilla on a friends computer, entered a bogus hostname and no port value to see if it would failover to a direct connection. The installer does run off the direct connection (b/c port==0), but then when mozilla launches, it went deaf b/c it inhereted the port number of a previous proxy install: all-proxy.ja: pref("network.proxy.http_port", 443); pref("network.proxy.type", 1); pref("network.proxy.http", "asdfasdf"); pref("network.proxy.type", 1); Can't someone make a one-line change and blow the file away rather than append the file? Totally easy, and easy to reproduce, for that matter.

nsbeta1+ per buffy traige

minusing for buffy triage

-> defaults. I shouldn't be the owner.

I'm going to see if I can get a patch for this.

-> --

Here's the source of the problem, the function originally appeneded to all.js. bug 39015 comment 10.

The problem is this line: if((fJSFile = fopen(szJSFile, "a+t")) != NULL) My c is very rusty, but all that needs to be done is to change it to create a file instead of appending.

(I did not build this patch)

Comment on attachment 148052 [details] [diff] [review] over-writes all-proxy.js, rather than appends r=ssu

Comment on attachment 148052 [details] [diff] [review] over-writes all-proxy.js, rather than appends sr=dveditz

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer