Closed
Bug 738700
Opened 13 years ago
Closed 13 years ago
xpc_UnmarkGrayObject should take nsISupports, not nsIXPConnectWrappedJS
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Every existing caller of this function ends up QIing from nsISupports anyways, and I think the current setup requires the caller knowing what nsIXPConnectWrappedJS is, which is only available in some places. This was giving me trouble when I was trying to call it in the observer service. I'm also going to rename the function.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → continuation
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #608851 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 610260 [details] [diff] [review]
minor cleanup
Try run looked fine (same one as the other patch).
Attachment #610260 -
Flags: review?(bugs)
|
||
Updated•13 years ago
|
Attachment #610260 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Thanks for the reviews.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec1874ee6dc3
Target Milestone: --- → mozilla14
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•