Closed
Bug 740185
Opened 13 years ago
Closed 13 years ago
Mark safe JS context black
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [snappy])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This is kept alive for the lifetime of the browser, and adds 100 or so nodes to the CC graph.
Assignee | ||
Comment 1•13 years ago
|
||
I was trying to avoid adding code to nsContentUtils, but that would have required exposing the definition of nsIThreadJSContextStack to nsCCUncollectableMarker, which seems to be a somewhat private XPConnect class.
Assignee: nobody → continuation
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #610356 -
Attachment is obsolete: true
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 610368 [details] [diff] [review]
fix if braces
Try run looked good https://tbpl.mozilla.org/?tree=Try&rev=c9baf630c73c
Attachment #610368 -
Flags: review?(bugs)
Updated•13 years ago
|
Whiteboard: [snappy]
Comment 4•13 years ago
|
||
Comment on attachment 610368 [details] [diff] [review]
fix if braces
>+nsContentUtils::TraceSafeJSContext(JSTracer *aTrc)
>+{
>+ if (!sThreadJSContextStack) {
>+ return;
>+ }
>+ JSContext* cx = nsnull;
>+ sThreadJSContextStack->GetSafeJSContext(&cx);
>+ if (!cx) {
>+ return;
>+ }
>+ if (JSObject *global = JS_GetGlobalObject(cx)) {
>+ JS_CALL_OBJECT_TRACER(aTrc, global, "safe context");
>+ }
Nit, you're not consistent with *.
JSContext* but JSObject *
I prefer JSContext*
Attachment #610368 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Good point. I'm bad about that. I changed them all to Foo*.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a60f2559489
Target Milestone: --- → mozilla14
Assignee | ||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•