Closed Bug 740354 Opened 13 years ago Closed 11 years ago

Source Editor should highlight numbers

Categories

(DevTools :: Source Editor, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cedricv, Unassigned)

References

Details

(Whiteboard: [sourceeditor][orion])

Numbers in the Source Editor are currently not highlighted, therefore black as regular text. However other tokens such as quoted strings or keywords (such as true/false) are. IMHO it would make sense to highlight numbers with a different color than black, as it helps readability and is a common settings in most syntax highlighters.
Thanks for your report Cedric! I also reported this request upstream: https://bugs.eclipse.org/bugs/show_bug.cgi?id=375666 (this needs some small orion changes)
Priority: -- → P3
Whiteboard: [sourceeditor][orion]
This is now fixed upstream. The fix will land in Firefox with the next Orion update.
(In reply to Mihai Sucan [:msucan] from comment #2) > This is now fixed upstream. The fix will land in Firefox with the next Orion > update. When is it? Do we have a bug for that? Can we mark this bug dependent on the Orion update bug?
(In reply to Paul Rouget [:paul] from comment #3) > (In reply to Mihai Sucan [:msucan] from comment #2) > > This is now fixed upstream. The fix will land in Firefox with the next Orion > > update. > > When is it? Do we have a bug for that? Can we mark this bug dependent on the > Orion update bug? I can open a new bug for updating Orion from upstream, but I can't comment on when that will land. The next Orion update will be "big" in technical terms - not big in terms of features / not something that users will notice. The next Orion update requires i18n work, requires closer inspection of possible regressions (they've removed the Orion iframe, which means we now have to update some of our code, and this also impacts initialization - I typically "fear" oranges when changes like these happen) and they probably made other important code changes that I haven't looked into yet.
Mihai, forget about what I said. I thought it was a little "simpler" than that :)
Depends on: 759351
Moving to Source Editor component. Filter on CHELICERAE.
Component: Developer Tools → Developer Tools: Source Editor
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.