Closed Bug 74113 Opened 24 years ago Closed 24 years ago

Trunk crash on page reload [@ nsImageListener::FrameChanged]

Categories

(Core :: Graphics: ImageLib, defect, P2)

x86
All
defect

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: mwitbrock, Assigned: pavlov)

References

()

Details

(Keywords: crash, topcrash)

Crash Data

Attachments

(1 file)

Got to http://rhyme.lycoszone.com Hit reload Crash (100% repeatable for me) 2001032904 [This URL's contents may change over the next day or two, so it may be good to try to check this bug soon] I'm just guessing that this is a cache problem.
Wfm with 2001032920 / Win98SE.
Whiteboard: [cache]
confirming with win2k / build 2001032804 Talkback ID : TB28468918Z
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: crash
Severity: blocker → critical
It looks like imglib2 is involved here: after several assertions ###!!! ASSERTION: not a container: 'PR_FALSE', file ../../../../../mozilla/layout/html/base/src/nsFrame.cpp, line 350 ###!!! Break: at file ../../../../../mozilla/layout/html/base/src/nsFrame.cpp, line 350 the crash happens here: #0 0x41c6b076 in nsImageListener::FrameChanged (this=0x877d458, aContainer=0x874ddf0, aContext=0x867c920, newframe=0x8882850, dirtyRect=0xbfffebf4) at ../../../../../mozilla/layout/html/base/src/nsImageFrame.cpp:1758 this = (nsImageListener *) 0x877d458 pc = {mRawPtr = 0x867c920} #1 0x41f65957 in imgRequestProxy::FrameChanged (this=0x87e8e98, container=0x874ddf0, cx=0x0, newframe=0x8882850, dirtyRect=0xbfffebf4) at ../../../../mozilla/modules/libpr0n/src/imgRequestProxy.cpp:204 this = (imgRequestProxy *) 0x87e8e98 #2 0x41f6338f in imgRequest::FrameChanged (this=0x8794508, container=0x874ddf0, cx=0x0, newframe=0x8882850, dirtyRect=0xbfffebf4) at ../../../../mozilla/modules/libpr0n/src/imgRequest.cpp:299 ob = (imgIDecoderObserver *) 0x87e8e9c this = (imgRequest *) 0x8794508 LOG_SCOPE_TMP_VAR__LINE__ = {mLog = 0x8282160, mFrom = 0x8794508, mFunc = {<nsCString> = {<basic_nsAWritableString<char>> = {<basic_nsAReadableString<char>> = {<nsPrivateSharableString<char>> = { _vptr. = 0x401dab40 <nsCAutoString virtual table>}, <No data fields>}, <No data fields>}, <nsStr> = {mLength = 24, mCapacity = 63, mCharSize = eOneByte, mOwnsBuffer = 0, { mStr = 0xbfffeae8 "imgRequest::FrameChanged", mUStr = 0xbfffeae8}}, <No data fields>}, mBuffer = "imgRequest::FrameChanged\000\200\a@\002\000\000\000а¤\035@P(\210\b\000\000\000\000\000\000\000\0004ляїlp\006@4ляї«дцA"}} i = 0 count = 1 #3 0x41f60581 in imgContainer::Notify (this=0x874ddf0, timer=0x8883700) at ../../../../mozilla/modules/libpr0n/src/imgContainer.cpp:398 frameToUse = {mRawPtr = 0x8882850} observer = {mRawPtr = 0x879450c} nextFrame = {mRawPtr = 0x8732240} timeout = 100 numFrames = 6 previousAnimationFrameIndex = 0 dirtyRect = {x = 425, y = 1, width = 43, height = 48} (note: line numbers are only valid for the mozilla-source from March 30th: NS_IMETHODIMP nsImageListener::FrameChanged(imgIContainer *aContainer, nsISupports *aContext, gfxIImageFrame *newframe, nsRect * dirtyRect) { if (!mFrame) return NS_ERROR_FAILURE; nsCOMPtr<nsIPresContext> pc(do_QueryInterface(aContext)); NS_ASSERTION(pc, "not a pres context!"); 1758--> return mFrame->FrameChanged(aContainer, pc, newframe, dirtyRect); } #endif NS_IMETHODIMP nsImageFrame::FrameChanged(imgIContainer *aContainer, nsIPresContext *aPresContext, gfxIImageFrame *aNewFrame, nsRect *aDirtyRect) { float p2t; aPresContext->GetPixelsToTwips(&p2t); nsRect r(*aDirtyRect); r *= p2t; // convert to twips mTransform.TransformCoord(&r.x, &r.y, &r.width, &r.height); Invalidate(aPresContext, r, PR_FALSE); return NS_OK; }
*** Bug 74314 has been marked as a duplicate of this bug. ***
OS: Windows 2000 → All
Summary: Crash on page reload → Crash on page reload in nsImageListener::FrameChanged
*** Bug 74373 has been marked as a duplicate of this bug. ***
I don't see the cache in the stack trace. Pav, is this really a cache bug, or does it belong to ImgLib2
Assignee: gordon → pavlov
Component: Networking: Cache → ImageLib
Whiteboard: [cache]
*** Bug 74973 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: tever → tpreston
Target Milestone: --- → mozilla0.9
*** Bug 75217 has been marked as a duplicate of this bug. ***
Attached file testcase (deleted) —
load the attached testcase into mozilla. *ASSERT* when it finishes loading, hit reload. *ASSERT* crash.
load the page... 2 image frames get created. hit reload...... 1 image frame gets destroyed. ... 2 image frames get created. .... crash layout bug?
the patch to nsCSSFrameConstructor in bug 73547 fixes this bug.
Depends on: 73547
pollmann checked in the fix for 73547. marking this one fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified fixed on Win98 build 2001041104 Verified fixed on Mac build 2001041108 Verified fixed on Linux build 2001041108
Status: RESOLVED → VERIFIED
I know this is fixed, but adding Trunk and [@ nsImageListener::FrameChanged] to summary and topcrash keyword since this *was* a topcrash in recent builds.
Keywords: topcrash
Summary: Crash on page reload in nsImageListener::FrameChanged → Trunk crash on page reload [@ nsImageListener::FrameChanged]
Crash Signature: [@ nsImageListener::FrameChanged]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: