Closed
Bug 741842
Opened 13 years ago
Closed 13 years ago
Improve BCP 47 language tag support (extension, singleton, privateuse)
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: GPHemsley, Assigned: GPHemsley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [bcp47])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I realized that bug 730209 doesn't support BCP 47 language tags that make use of extensions or private use subtags. At present, if such a language tag is the name of a dictionary, it will (I believe) display the entire language tag raw. A better behavior, I think, would be to simply ignore the extension and privateuse subtags if they are unsupported (which they currently are).
In addition, the tests included in that bug are not as exhaustive as they could be, so that should also be improved.
(I have code for this already; patch will be attached shortly.)
Assignee | ||
Comment 1•13 years ago
|
||
Updates the regexp and adds a bunch of tests.
Attachment #611861 -
Flags: review?(gavin.sharp)
Comment 2•13 years ago
|
||
Comment on attachment 611861 [details] [diff] [review]
Improve support for extension and privateuse subtags
rs=me
Attachment #611861 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=ba49a841ccef
Keywords: checkin-needed
Comment 4•13 years ago
|
||
Assignee: nobody → gphemsley
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla14
Assignee | ||
Comment 5•13 years ago
|
||
Ugh, I forgot to mention explicitly that this code presupposes the code for bug 716321. Since that code is not yet in m-i/m-c, I think we'll wind up with a failing test.
The test on line 106 of toolkit/content/tests/browser/browser_InlineSpellChecker.js ('es-419') should be marked as todo_is.
Depends on: 716321
Comment 6•13 years ago
|
||
Changed the test to todo_is.
https://hg.mozilla.org/integration/mozilla-inbound/rev/031f54b05818
Assignee | ||
Comment 7•13 years ago
|
||
Here's the patch with the change integrated into, in case it's needed.
Attachment #611861 -
Attachment is obsolete: true
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•