Closed Bug 741980 Opened 13 years ago Closed 13 years ago

[traceback] fetch icon task fails for app manifest with empty icons dict

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

All
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: kumar, Assigned: andy+bugzilla)

References

Details

STR: 1. submit an app with this manifest http://people.mozilla.com/~kmcmillan/no-icons.webapp to the dev site or your local dev site The app gets submitted but the fetch icon task fails with this: Traceback (most recent call last): File "/Users/kumar/dev/zamboni/vendor/src/django/django/core/servers/basehttp.py", line 283, in run self.result = application(self.environ, self.start_response) File "/Users/kumar/dev/zamboni/vendor/src/django/django/contrib/staticfiles/handlers.py", line 68, in __call__ return self.application(environ, start_response) File "/Users/kumar/dev/zamboni/vendor/src/django/django/core/handlers/wsgi.py", line 272, in __call__ response = self.get_response(request) File "/Users/kumar/dev/zamboni/vendor/src/django/django/core/handlers/base.py", line 169, in get_response response = self.handle_uncaught_exception(request, resolver, sys.exc_info()) File "/Users/kumar/dev/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File "/Users/kumar/dev/zamboni/apps/amo/decorators.py", line 112, in wrapper return f(*args, **kw) File "/Users/kumar/dev/zamboni/apps/amo/decorators.py", line 104, in wrapper return f(*args, **kw) File "/Users/kumar/dev/zamboni/apps/amo/decorators.py", line 29, in wrapper return func(request, *args, **kw) File "/Users/kumar/dev/zamboni/mkt/submit/decorators.py", line 19, in wrapper return f(request, *args, **kw) File "/Users/kumar/dev/zamboni/mkt/submit/views.py", line 76, in manifest tasks.fetch_icon.delay(addon) File "/Users/kumar/dev/zamboni/vendor/lib/python/celery/app/task/__init__.py", line 371, in delay return self.apply_async(args, kwargs) File "/Users/kumar/dev/zamboni/vendor/src/nuggets/celeryutils.py", line 22, in apply_async return super(Task, self).apply_async(args, kwargs, **options) File "/Users/kumar/dev/zamboni/vendor/lib/python/celery/app/task/__init__.py", line 463, in apply_async return self.apply(args, kwargs, task_id=task_id, **options) File "/Users/kumar/dev/zamboni/vendor/lib/python/celery/app/task/__init__.py", line 616, in apply request=request, propagate=throw) File "/Users/kumar/dev/zamboni/vendor/lib/python/celery/execute/trace.py", line 220, in eager_trace_task uuid, args, kwargs, request) File "/Users/kumar/dev/zamboni/vendor/lib/python/celery/execute/trace.py", line 153, in trace_task R = retval = task(*args, **kwargs) File "/Users/kumar/dev/zamboni/vendor/src/nuggets/celeryutils.py", line 35, in wrapped return fun(*args, **kw) File "/Users/kumar/dev/zamboni/apps/amo/decorators.py", line 112, in wrapper return f(*args, **kw) File "/Users/kumar/dev/zamboni/apps/amo/decorators.py", line 104, in wrapper return f(*args, **kw) File "/usr/local/Cellar/python2.6/2.6.5/lib/python2.6/contextlib.py", line 34, in __exit__ self.gen.throw(type, value, traceback) File "/Users/kumar/dev/zamboni/apps/amo/models.py", line 40, in skip_cache yield File "/Users/kumar/dev/zamboni/apps/amo/decorators.py", line 104, in wrapper return f(*args, **kw) File "/Users/kumar/dev/zamboni/mkt/developers/tasks.py", line 334, in fetch_icon biggest = max([int(size) for size in manifest['icons']]) ValueError: max() arg is an empty sequence
Blocks: 735054
Hardware: x86 → All
Priority: -- → P2
Assignee: nobody → amckay
Target Milestone: --- → 6.5.1
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
This doesn't traceback anymore
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.