Closed
Bug 742176
Opened 13 years ago
Closed 10 years ago
Text frames have an overflow area which is too small on Windows
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: ehsan.akhgari, Assigned: jfkthame)
Details
Attachments
(1 file)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
See bug 157681 comment 71 for steps to reproduce!
Reporter | ||
Comment 1•13 years ago
|
||
Note that the work-around in attachment 612095 [details] [diff] [review] should be removed once this bug is fixed.
Assignee | ||
Comment 2•10 years ago
|
||
Is this still a problem, or can we resolve it as WFM? It looks to me like "the work-around in attachment 612095 [details] [diff] [review]" never actually landed in the tree....
Flags: needinfo?(ehsan)
Reporter | ||
Comment 3•10 years ago
|
||
The workarounds landed as fuzzy-if annotations: https://dxr.mozilla.org/mozilla-central/search?q=742176
I guess you can remove them and see if the tests fail to see if this is still an issue...
Flags: needinfo?(ehsan)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #3)
> The workarounds landed as fuzzy-if annotations:
> https://dxr.mozilla.org/mozilla-central/search?q=742176
>
> I guess you can remove them and see if the tests fail to see if this is
> still an issue...
See try run in comment 4. Note that only one of the tests failed, and it's apparently less "fuzzy" than it used to be, judging by the numbers in the annotation.
Also, checking the reftest analyzer images, the discrepancy is NOT at the boundaries of the area being drawn, as we'd expect if it's a problem with visual overflow areas. Rather, it's one of the mid-word glyphs that is rendered with slightly different subpixel antialiasing between the testcase and reference. That's not an indication of overflow-area problems.
Reporter | ||
Comment 6•10 years ago
|
||
It's very well possible that the original issue has been fixed, or it still exists but this test case doesn't hit it any more. I don't think this bug is actionable any more.
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
OK, I propose we tighten up the annotations on these tests, and then we'll close this as WorksForMe given that we're not seeing overflow-area issues here any more.
Attachment #8590255 -
Flags: review?(ehsan)
Reporter | ||
Updated•10 years ago
|
Attachment #8590255 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
OS: Mac OS X → Windows
Resolution: --- → WORKSFORME
Comment 12•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•