phase 1: changes to necko core phase 2: changes to necko http

the attached files and patches complete phase 1 of these necko api changes. the new source files go in netwerk/base/src/ and the new idl files go in netwerk/base/public/ phase 1 bugs include: bug 71054 bug 71058 bug 71059 bug 72689 bug 72690

Things changed: * made nsIChannel::URI readonly * moved NS_LOADGROUP_CID from nsILoadGroup.idl to nsNetCID.h Things remaining: * figure out what to do with nsIChannel::owner Things that won't be done: * move securityInfo to nsISecureChannel

darin, can you give me a "what this is in 10 words or less"? What's the motivation? Are the changes mostly mechanical, etc?

asa: valeski, rpotts, vidur, dougt, and myself developed a list of changes that should be made to necko before certain interface files can be considered frozen and thus part of the embedding api.

so, these last three diff's represent what i hope will be the final cut of these "phase 1" changes. i've left |owner| and |securityInfo| on nsIChannel. the attachments that need reviewing are: http://bugzilla.mozilla.org/showattachment.cgi?attach_id=29796 (src.tar.gz) http://bugzilla.mozilla.org/showattachment.cgi?attach_id=29789 (aim.diff) http://bugzilla.mozilla.org/showattachment.cgi?attach_id=29792 (necko.diff) http://bugzilla.mozilla.org/showattachment.cgi?attach_id=29793 (other.diff)

the source tarball contains the following files (i unfortunately did not include path information in the tarball, so i've annotated below the expected locations of the individual files): nsEventSender.h --> /netwerk/base/src nsRequestObserverProxy.h --> /netwerk/base/src nsEventSender.cpp --> /netwerk/base/src nsRequestObserverProxy.cpp --> /netwerk/base/src nsIRequestObserver.idl --> /netwerk/base/public nsIRequestObserverProxy.idl --> /netwerk/base/public

aim.diff - r=valeski - necko.diff - (I'm cross-eyed after reading this diff) nsILoadGroup.idl * why did you remove the "@status UNDER_REVIEW" comment? We should actually move it to FROZEN. nsIRequest.idl * why did you remove the "@status UNDER_REVIEW" comment? We should actually move it to FROZEN, or if we still might be adding the owner here, keep it UNDER_REVIEW. nsLoadGroup.cpp * ::SetGroupObserver() - I believe the mObserver = 0; is redundant. - other.diff - r=valeski - tar files - r=valeski w/ the following change. nsIRequestObserver.idl * please add the following to the iface comments @status FROZEN @version 1.0

jud: thanks for the review... i'll apply the FROZEN tags as you suggest. do you want "@version 1.0" on the other IDL files as well??

right now, @version is only applicable to @status FROZEN apis, and the other's aren't public at this point, so we can leave them alone.

the last three attachments reflect the final revisions of these changes. i've incorporated jud's suggestions, along with the following changes: 1) applied rpott's patch to nsRequestObserverProxy to use GetStatus() for the status passed through OnStopRequest. 2) updated IDL files (nsIRequest.idl, nsIRequestObserver.idl, and nsILoadGroup.idl) with @status FROZEN, @version 1.0 3) added NS_BINDING_REDIRECTED and NS_BINDING_RETARGETED nsresults to nsIRequestObserver.idl, per discussion with rpotts 4) removed aStatusArg from OnStopRequest... yay!! 5) collapsed nsEventSender class back into nsRequestObserverProxy... this might be pulled out and added to xpcom later on. for now, it should just stay in nsRequestObserverProxy where it originally was. OK, and that's it. Jud has said that his r= still stands despite these changes, so now i'm just waiting for an sr.

sr=rpotts. -- rick

phase 2 isn't going to be completed for 0.9

http api revision is complete.