Closed
Bug 742528
Opened 13 years ago
Closed 12 years ago
Read Only Disabled When Calendar Is Cached
Categories
(Calendar :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.9.1
People
(Reporter: asai, Assigned: mmecca)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
Fallen
:
review+
redDragon
:
feedback+
mmecca
:
approval-calendar-aurora+
mmecca
:
approval-calendar-beta+
mmecca
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Build ID: 20120129021758
Steps to reproduce:
Create new CalDAV calendar, check Cache and Read-Only
Actual results:
Upon restarting TB, Read-Only is unchecked. Upon unchecking Cache checking Read-Only, Read-Only stays on.
Expected results:
Read-Only should stay checked.
Confirming. Have the exact same issue. For me it only appeared in Lightning 1.5, just like described in bug 772041.
I am on Arch Linux x64, so it would be great if someone could change this bug back to "OS: All"
Comment 3•12 years ago
|
||
I can also confirm this bug on Ubuntu 12.04 amd64 with Thunderbird 15 and Lightning 1.7
Updated•12 years ago
|
Blocks: calcache
Status: UNCONFIRMED → NEW
Component: Lightning Only → General
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•12 years ago
|
||
The read-only property is being set to false after reading the offline properties from the cache (also the disabled property, but I don't think this will work anyway without using setProperty).
Mohit, is there any reason this shouldn't be removed?
Attachment #682810 -
Flags: review?(philipp)
Attachment #682810 -
Flags: feedback?(mohit.kanwal)
Updated•12 years ago
|
Attachment #682810 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 8•12 years ago
|
||
Pushed to comm-central - https://hg.mozilla.org/comm-central/rev/62ed8249ff31
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2
Comment 9•12 years ago
|
||
Comment on attachment 682810 [details] [diff] [review]
Fix v1
Review of attachment 682810 [details] [diff] [review]:
-----------------------------------------------------------------
This should be good to go. If I remember correctly this was done to prevent the offline cache getting rewritten and thus raising of the mItemInfoCache[aItem.id] not found error. I guess we can safely remove this.
Attachment #682810 -
Flags: feedback?(mohit.kanwal) → feedback+
Comment 10•12 years ago
|
||
Could it be backported? It is a trivial fix without any risk from what I see. Right now, I'm being shown the invitations addressed to all my colleagues instead of just mine. If I disable caching and enable read only for other calendars, pending invitations only display the one addressed to my calendar as intended.
Comment 11•12 years ago
|
||
Comment on attachment 682810 [details] [diff] [review]
Fix v1
Matt, I'll leave the decision to you if you want this in 1.9.x ?
Attachment #682810 -
Flags: approval-calendar-release?(matthew.mecca)
Attachment #682810 -
Flags: approval-calendar-beta?(matthew.mecca)
Attachment #682810 -
Flags: approval-calendar-aurora?(matthew.mecca)
Assignee | ||
Updated•12 years ago
|
Attachment #682810 -
Flags: approval-calendar-release?(matthew.mecca)
Attachment #682810 -
Flags: approval-calendar-release+
Attachment #682810 -
Flags: approval-calendar-beta?(matthew.mecca)
Attachment #682810 -
Flags: approval-calendar-beta+
Attachment #682810 -
Flags: approval-calendar-aurora?(matthew.mecca)
Attachment #682810 -
Flags: approval-calendar-aurora+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [wanted-1.9.x]
Assignee | ||
Comment 12•12 years ago
|
||
Target Milestone: 2.2 → 2.1
Assignee | ||
Comment 13•12 years ago
|
||
Target Milestone: 2.1 → 1.9.1
Assignee | ||
Updated•12 years ago
|
Whiteboard: [wanted-1.9.x]
You need to log in
before you can comment on or make changes to this bug.
Description
•