Closed Bug 742672 Opened 13 years ago Closed 13 years ago

GCLI needs a new home

Categories

(DevTools :: Console, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 2 obsolete files)

Currently GCLI lives in various files in 'webconsole', but this is an articfact of history because it is now used entirely by the developer toolbar in 'shared', and not by anything in 'webconsole'. I propose a new devtools/gcli directory. At the same time we should: - Use devtools/gcli/generated for files from the GCLI project I think this directory would contain 3 files (probably) for GCLI modules The point of the separation is to make it clearer which files have an external source - Split console.js out so it doesn't have to be duplicated - Split the module loader out so it doesn't have to be duplicated (both of these probably should live in 'shared') - Split gcli.jsm into: - devtools/gcli/gcli.jsm ('public' interface for devtools) - devtools/gcli/generated/common-modules.jsm (imported modules, see above) - Move command-loading from DeveloperToolbar to gcli.jsm - Work to get as many firefox resources out of gcli and into central
Blocks: 745773
Attached patch Upload 1 (obsolete) (deleted) — Splinter Review
Rob - there's a ton of stuff here, I'm happy to talk it through with you - I think that would probably save lots of time.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #622427 - Flags: review?(rcampbell)
Some additional context for this move: - I'd like to take any breaking changes for the GCLI API now rather than later If moving things around could break commands then we want to do this now. - The NetPanel import depends on the files we split out here.
Can we call the directory 'commandline' so that people have a chance of finding it without knowing our esoteric name for the command line?
(In reply to Dave Camp (:dcamp) from comment #3) > Can we call the directory 'commandline' so that people have a chance of > finding it without knowing our esoteric name for the command line? sensible.
Attached patch Upload 2 (obsolete) (deleted) — Splinter Review
Fixes known issues
Attachment #622427 - Attachment is obsolete: true
Attachment #622427 - Flags: review?(rcampbell)
Attachment #624166 - Flags: review?(rcampbell)
Blocks: 749397
Comment on attachment 624166 [details] [diff] [review] Upload 2 per discussion in IRC.
Attachment #624166 - Flags: review?(rcampbell) → review+
Attached patch Upload 3 (deleted) — Splinter Review
Fixes Rob's comments from IRC: - License header was incorrectly standard Firefox header, changed back to reflect gcli license. - Gcli.jsm vs GCLI.jsm: I left it as it originally was gcli.jsm I think the lowercase.jsm for imported modules we discussed originally makes lots of sense. Lets stick with that. Also: https://tbpl.mozilla.org/?tree=Try&rev=247f6c538eb3
Attachment #624166 - Attachment is obsolete: true
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 758819
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: