Closed
Bug 742797
Opened 13 years ago
Closed 13 years ago
B2G Wifi: Fix wifi shutdown (and restart) on ICS
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
There are a couple of bugs making us unable to restart wifi. This is the most important one. I'll file another bug tomorrow on the remaining stuff.
|
Assignee | |
Comment 1•13 years ago
|
||
This patch does the following:
- Sending TERMINATE terminates the supplicant gracefully.
- Calling closeSupplicantConnection would have fixed this bug alone, but in general it resets wifi.c's internal socket state and prevents us from reusing the old sockets when we restart.
- closeSupplicantConnection returns void, not int, so we shouldn't try to get a return value from it.
Does this fix bug 740719?
|
|
Assignee | |
Comment 3•13 years ago
|
||
As far as I can tell, it doesn't. However it does allow the wifi component to shut down (which is a bug fix that would affect that bug). Note that I've locally removed the error checking on this path. Each function call tries harder to kill the supplicant, so a failure to kill it in one function shouldn't stop us from continuing.
|
||
Updated•13 years ago
|
Attachment #612610 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•