This patch adds Debugger objects to the cross-compartment map. I have a later patch where I want to be able to easily iterate over all cross-compartment references.

Comment on attachment 612642 [details] [diff] [review] patch Review of attachment 612642 [details] [diff] [review]: ----------------------------------------------------------------- This looks great. r=me. ::: js/src/jscompartment.cpp @@ +504,5 @@ > + JS_ASSERT(static_cast<Cell *>(value.toGCThing())->compartment() == this); > + > + if (IsAboutToBeFinalized(key.wrapped) || > + IsAboutToBeFinalized(value) || > + (key.debugger && IsAboutToBeFinalized(key.debugger))) OK. This is the only tricky bit, and I think this is correct. IsAboutToBeFinalized(value) will never be true if key.debugger and key.wrapped are both still live, thanks to all that complex markAllIteratively code in Debugger.cpp that you left as-is. Right? ::: js/src/jscompartment.h @@ +179,5 @@ > + Kind kind; > + JSObject *debugger; > + js::gc::Cell *wrapped; > + > + CrossCompartmentKey() {} Maybe initialize to NULL. (HashMap::remove requires this default constructor; the value is never used, so an empty constructor is correct--but deterministic behavior is correct too and only costs a few insns. Your call.)

(In reply to Jason Orendorff [:jorendorff] from comment #1) > IsAboutToBeFinalized(value) will never be true if key.debugger and > key.wrapped are both still live, thanks to all that complex > markAllIteratively code in Debugger.cpp that you left as-is. Right? This is true, but I think it's because of the weakmap that the debugger keeps from Objects to Debugger.Objects. If the debugger is alive, its weakmap is traced. The weakmap key is key.wrapped, and if that's alive then the weakmap keeps value alive.

Agreed.

I've got this running on tryserver now.