Closed
Bug 743413
Opened 13 years ago
Closed 13 years ago
Move some misc Utils functions into common
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: gps, Assigned: gps)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Need to move some misc Utils functions into common to support a 200KB patch I'm working on.
Attachment #613053 -
Flags: review?(rnewman)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 613053 [details] [diff] [review]
Move some code
Review of attachment 613053 [details] [diff] [review]:
-----------------------------------------------------------------
::: services/common/utils.js
@@ +126,5 @@
> + encodeUTF8: function encodeUTF8(str) {
> + try {
> + str = this._utf8Converter.ConvertFromUnicode(str);
> + return str + this._utf8Converter.Finish();
> + } catch(ex) {
Nit: space.
@@ +135,5 @@
> + decodeUTF8: function decodeUTF8(str) {
> + try {
> + str = this._utf8Converter.ConvertToUnicode(str);
> + return str + this._utf8Converter.Finish();
> + } catch(ex) {
Nit: space.
Attachment #613053 -
Flags: review?(rnewman) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: [fixed in services]
|
||
Updated•13 years ago
|
Whiteboard: [fixed in services] → [fixed in services][qa-]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla14
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•