Closed
Bug 744158
Opened 13 years ago
Closed 13 years ago
ttest.py (or similar) should remove the browser_log from the device
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Assigned: k0scist)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
k0scist
:
review-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
We currently delete the browser_log from (local) disk for each browser
cycle:
http://hg.mozilla.org/build/talos/file/4343f5e91fae/talos/ttest.py#l262
However, we do not remove it from the remote device. This leads to
multiple-cycle runs whose browser_logs don't match what local
browser_logs do, causing issues like
https://bugzilla.mozilla.org/show_bug.cgi?id=742937#c18
I'm not sure of the full ramifications here. I am very surprised that
our existing regexs and subsequent processing work
(http://hg.mozilla.org/build/talos/file/4343f5e91fae/talos/ttest.py#l75)
and am not sure how they + subsequent processing of results data are
currently work.
IMHO the thing to do is just wipe the browser_log from the remote
device between browser cycles and have parity here.
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
updated with a fix for non remote cases.
Attachment #613965 -
Attachment is obsolete: true
Attachment #613965 -
Flags: review?(jhammel)
Attachment #613976 -
Flags: review?(jhammel)
Comment 3•13 years ago
|
||
Try run for f10a39a932b2 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=f10a39a932b2
Results (out of 50 total builds):
exception: 11
success: 4
failure: 35
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jmaher@mozilla.com-f10a39a932b2
Comment 4•13 years ago
|
||
Try run for bdbf7f88656d is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=bdbf7f88656d
Results (out of 46 total builds):
exception: 15
success: 4
warnings: 1
failure: 26
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jmaher@mozilla.com-bdbf7f88656d
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 613976 [details] [diff] [review]
remove the log file from the device before running the test (1.1)
+ for bundlename in browser_config['bundles']:
+ self._ffsetup.InstallBundleInBrowser(browser_config['browser_path'],
+ bundlename,
+ browser_config['bundles'][bundlename])
+
We definitely don't want these :)
I have a patch in the works too
Attachment #613976 -
Flags: review?(jhammel) → review-
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #614049 -
Flags: review?(jmaher)
Comment 7•13 years ago
|
||
Comment on attachment 614049 [details] [diff] [review]
remove browser_log and some cleanup
Review of attachment 614049 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #614049 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 8•13 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e5e9b6853290
Assignee: jmaher → jhammel
Comment 9•13 years ago
|
||
Try run for e5e9b6853290 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=e5e9b6853290
Results (out of 75 total builds):
success: 74
failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-e5e9b6853290
Comment 10•13 years ago
|
||
I reran the failure and it passed.
Comment 11•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•