Closed
Bug 744417
Opened 13 years ago
Closed 13 years ago
B2G Wifi: better nsIDOMWifiManager.forgetNetwork function
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: kaze, Assigned: kaze)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
The current `forgetNetwork' implementation is buggy because it couldn’t be tested so far. Here’s a quick fix that works with my current Gaia tree: https://github.com/fabi1cazenave/gaia/tree/wifi
Assignee | ||
Comment 1•13 years ago
|
||
mrbkap > for my information, what’s the difference between var request = this.createRequest(); and var request = Services.DOMRequest.createRequest(this._window); ? In DOMWifiManager.js, the latter is only used for `forget' — the former is used everywhere else.
Comment 2•13 years ago
|
||
Comment on attachment 614009 [details] [diff] [review] patch proposal The two versions of createRequest are equivalent. Please do change the one in forget for consistency though. Thanks a lot and sorry for the typos!
Attachment #614009 -
Flags: review+
Assignee | ||
Comment 3•13 years ago
|
||
same patch, now using `this.createRequest()' for better consistency.
Attachment #614009 -
Attachment is obsolete: true
Assignee | ||
Comment 4•13 years ago
|
||
sorry, did a `git diff >> patch' instead of a `git diff > patch'.
Assignee: nobody → kaze
Attachment #614042 -
Attachment is obsolete: true
Updated•13 years ago
|
Blocks: b2g-wifi
Summary: [wifi] better nsIDOMWifiManager.forgetNetwork function → B2G Wifi: better nsIDOMWifiManager.forgetNetwork function
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/63a7d74d01d8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•