Closed
Bug 744663
Opened 13 years ago
Closed 13 years ago
test_websocket_basic.html: additional improvements after bug 621347
Categories
(Core :: Networking: WebSockets, defect, P3)
Core
Networking: WebSockets
Tracking
()
VERIFIED
FIXED
mozilla14
People
(Reporter: sgautherie, Assigned: sgautherie)
References
(Blocks 1 open bug, )
Details
Attachments
(3 files)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Basically moving bug 621347 patch Cv1a here.
Assignee | ||
Comment 1•13 years ago
|
||
(In reply to Olli Pettay [:smaug] from bug 621347 comment #7)
> Kind of hard to see what is changed and why.
Here is a first part, to ease review.
Attachment #614246 -
Flags: review?(bugs)
Updated•13 years ago
|
Attachment #614246 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #615795 -
Flags: review?(bugs)
Comment 3•13 years ago
|
||
Comment on attachment 615795 [details] [diff] [review]
(Bv1) Inline finishWSTest(), Use executeSoon() between sub-tests, Improve message contents, Receive "end" messages too, Add an additional forcegc(), Nits
[Checked in: Comment 6]
Not sure why you want these changes, but ok :)
Attachment #615795 -
Flags: review?(bugs) → review+
Updated•13 years ago
|
Attachment #617586 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 614246 [details] [diff] [review]
(Av1) Improve documentation and logs, Nits
[Checked in: Comment 5]
https://hg.mozilla.org/mozilla-central/rev/30404871c57e
Attachment #614246 -
Attachment description: (Av1) Improve documentation and logs, Nits → (Av1) Improve documentation and logs, Nits
[Checked in: Comment 5]
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 615795 [details] [diff] [review]
(Bv1) Inline finishWSTest(), Use executeSoon() between sub-tests, Improve message contents, Receive "end" messages too, Add an additional forcegc(), Nits
[Checked in: Comment 6]
https://hg.mozilla.org/mozilla-central/rev/03b56b258f69
Attachment #615795 -
Attachment description: (Bv1) Inline finishWSTest(), Use executeSoon() between sub-tests, Improve message contents, Receive "end" messages too, Add an additional forcegc(), Nits → (Bv1) Inline finishWSTest(), Use executeSoon() between sub-tests, Improve message contents, Receive "end" messages too, Add an additional forcegc(), Nits
[Checked in: Comment 6]
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 617586 [details] [diff] [review]
(Cv1) Use 'test' pre instead of redundant 'log' pre, Improve on-screen logging
[Checked in: Comment 7]
https://hg.mozilla.org/mozilla-central/rev/21da3f655b30
Attachment #617586 -
Attachment description: (Cv1) Use 'test' pre instead of redundant 'log' pre, Improve on-screen logging → (Cv1) Use 'test' pre instead of redundant 'log' pre, Improve on-screen logging
[Checked in: Comment 7]
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 8•13 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=11141200&tree=Firefox&full=1
Rev3 Fedora 12x64 mozilla-central debug test mochitests-1/5 on 2012-04-23 18:55:43 PDT for push 21da3f655b30
{
40185 INFO TEST-START | /tests/content/base/test/test_websocket_basic.html
40186 INFO TEST-PASS | /tests/content/base/test/test_websocket_basic.html | [1] WebSocket.url - ws://mochi.test:8888/tests/content/base/test/file_websocket_basic should equal ws://mochi.test:8888/tests/content/base/test/file_websocket_basic
[...]
41308 INFO TEST-PASS | /tests/content/base/test/test_websocket_basic.html | [5] Length of buffered message sent after closing - 27 should equal 27
41309 INFO TEST-END | /tests/content/base/test/test_websocket_basic.html | finished in 36868ms
}
V.Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•