Closed
Bug 745119
Opened 13 years ago
Closed 13 years ago
Clean up TEST_URIs in webconsole tests
Categories
(DevTools :: Console, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jwalker, Assigned: capella)
Details
(Whiteboard: [good-first-bug][fixed-in-fx-team])
Attachments
(1 file)
|
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Robcee, in a review:
> const TEST_URI = "http://example.com/browser/browser/devtools/webconsole/test//test-console.html";
>
> we should file a follow-up to cleanup those URIs.
I think he's referring to the double slash, but I'm sure he can correct me.
|
||
Comment 1•13 years ago
|
||
(In reply to Joe Walker from comment #0)
> Robcee, in a review:
>
> > const TEST_URI = "http://example.com/browser/browser/devtools/webconsole/test//test-console.html";
> >
> > we should file a follow-up to cleanup those URIs.
>
> I think he's referring to the double slash, but I'm sure he can correct me.
exactly so.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
Patch posted ... 32 files modified ... gonna autoland to try to verify my local tests ...
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [good-first-bug] → [autoland-try: -b do -p linux64 -u all -t none][good-first-bug]
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [autoland-try: -b do -p linux64 -u all -t none][good-first-bug] → [good-first-bug]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 615253 [details] [diff] [review]
Patch (v1)
FYI https://tbpl.mozilla.org/?tree=Try&rev=bacfc257b906
Attachment #615253 -
Flags: review?(rcampbell)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 615253 [details] [diff] [review]
Patch (v1)
looks good, thanks Mark!
Attachment #615253 -
Flags: review?(rcampbell) → review+
|
|
||
Updated•13 years ago
|
Whiteboard: [good-first-bug] → [good-first-bug][land-in-fx-team]
|
||
Comment 5•13 years ago
|
||
Whiteboard: [good-first-bug][land-in-fx-team] → [good-first-bug][fixed-in-fx-team]
|
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Version: unspecified → 14 Branch
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•