Closed
Bug 745415
Opened 13 years ago
Closed 13 years ago
BrowserID module must use appShellService to append the hidden iframe
Categories
(Cloud Services :: Firefox: Common, defect)
Cloud Services
Firefox: Common
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: anant, Unassigned)
Details
The _createFrame method in the BrowserID module creates an iframe and appends it to the most recent browser window, which will fail if there was none. Instead, it should use appShellService to obtain a hiddenDOMWindow:
let appShell = Cc["@mozilla.org/appshell/appShellService;1"]
.getService(Ci.nsIAppShellService);
let hiddenDOMWindow = appShell.hiddenDOMWindow;
let doc = hiddenDOMWindow.document;
Reporter | ||
Comment 1•13 years ago
|
||
Fixed in the latest version of patch in bug 745345.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 2•12 years ago
|
||
Looks like this wasn't actually fixed in that patch?
Reporter | ||
Comment 3•12 years ago
|
||
One of the attachment versions had the fix: https://bug745345.bugzilla.mozilla.org/attachment.cgi?id=628588 but it didn't make it to the final version, I'm investigating why...
You need to log in
before you can comment on or make changes to this bug.
Description
•