Closed
Bug 745885
Opened 13 years ago
Closed 12 years ago
CommonUtils.namedTimer support for different timer types
Categories
(Cloud Services :: Firefox: Common, defect)
Cloud Services
Firefox: Common
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: gps, Assigned: gps)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
CommonUtils.namedTimer currently uses one shot timers and only one shot timers. I'd like to add an argument to support specifying the timer type.
Assignee | ||
Comment 1•13 years ago
|
||
Added support for arbitrary types. Also fixed style nits. Also fixed unit tests which called run_next_test() twice. Seriously.
Comment 2•13 years ago
|
||
Comment on attachment 615516 [details] [diff] [review]
namedTimer improvements, v1
Review of attachment 615516 [details] [diff] [review]:
-----------------------------------------------------------------
::: services/common/tests/unit/test_utils_namedTimer.js
@@ +64,5 @@
> + if (count < 2) {
> + return;
> + }
> +
> + do_check_true((Date.now() - t0) > 2 * delay);
Can you assign these two quantities to named locals for clarity?
Attachment #615516 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Whiteboard: [fixed in services]
Assignee | ||
Comment 4•13 years ago
|
||
xpcshell tests failing on Windows and Linux with this patch applied. Not OS X, however.
Assignee | ||
Comment 5•13 years ago
|
||
Whiteboard: [fixed in services]
Comment 6•13 years ago
|
||
[qa-] but I will be smoketesting Sync on s-c to be certain nothing is broken.
Whiteboard: [qa-]
Assignee | ||
Comment 7•13 years ago
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•