Closed Bug 745885 Opened 13 years ago Closed 12 years ago

CommonUtils.namedTimer support for different timer types

Categories

(Cloud Services :: Firefox: Common, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: gps, Assigned: gps)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

CommonUtils.namedTimer currently uses one shot timers and only one shot timers. I'd like to add an argument to support specifying the timer type.
Attached patch namedTimer improvements, v1 (deleted) — Splinter Review
Added support for arbitrary types. Also fixed style nits. Also fixed unit tests which called run_next_test() twice. Seriously.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #615516 - Flags: review?(rnewman)
Comment on attachment 615516 [details] [diff] [review] namedTimer improvements, v1 Review of attachment 615516 [details] [diff] [review]: ----------------------------------------------------------------- ::: services/common/tests/unit/test_utils_namedTimer.js @@ +64,5 @@ > + if (count < 2) { > + return; > + } > + > + do_check_true((Date.now() - t0) > 2 * delay); Can you assign these two quantities to named locals for clarity?
Attachment #615516 - Flags: review?(rnewman) → review+
xpcshell tests failing on Windows and Linux with this patch applied. Not OS X, however.
Whiteboard: [fixed in services]
[qa-] but I will be smoketesting Sync on s-c to be certain nothing is broken.
Whiteboard: [qa-]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: