Closed Bug 746217 Opened 13 years ago Closed 13 years ago

Cannot open windows even from the same domain

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [marketplace-beta-])

Attachments

(1 file)

When I try to call window.open("http://ed.agadak.net") from http://ed.agadak.net/app/ I get an exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMJSWindow.open]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: http://ed.agadak.net/app/ :: onClick :: line 26" data: no] This is problematic for the Marketplace app for bug 738816 which relies on Persona for login and that opens up a new window.
I wonder if the underlying issue is similar to bug 729853? I know there's been a lot of problems with being able to open pop-ups, windows, or anything that steps outside of the initial chromeless content presented to a user.
I get these warnings when trying to open a window from an app: WARNING: NS_ENSURE_TRUE(xulWin->mPrimaryContentShell) failed: file /builds/slave/try-osx64-dbg/build/xpfe/appshell/src/nsXULWindow.cpp, line 1810 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/slave/try-osx64-dbg/build/dom/base/nsGlobalWindow.cpp, line 8927 The latter one is in OpenInternal.. http://mxr.mozilla.org/mozilla-central/source/dom/base/nsGlobalWindow.cpp#8682 .. on this line.. http://mxr.mozilla.org/mozilla-central/source/dom/base/nsGlobalWindow.cpp#8823 The former is in CreateNewContentWindow.. http://mxr.mozilla.org/mozilla-central/source/xpfe/appshell/src/nsXULWindow.cpp#1759 .. on this line.. http://mxr.mozilla.org/mozilla-central/source/xpfe/appshell/src/nsXULWindow.cpp#1810
Blocks: 746229
I have a tryserver debug build that has windows opening, but the main window no longer scrolls. This was just changing the <xul:browser type="content-primary"> instead of just type="content". https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/edward.lee@engineering.uiuc.edu-45e9879bb692/try-macosx64-debug/firefox-14.0a1.en-US.mac64.dmg --- a/webapprt/content/webapp.xul +++ b/webapprt/content/webapp.xul @@ -151,1 +151,1 @@ - <browser type="content" id="content" flex="1"/> + <browser type="content-primary" id="content" flex="1"/> This build lets me log into Marketplace with Persona through the newly opened window, but the only way I can scroll in the main window is by clicking the page and using arrows/spacebar (mousescroll doesn't work and no scrollbars to drag).
Depends on: 725408
Attached patch wip v1 (deleted) — Splinter Review
Allows opening windows but first window doesn't have scrollbars.
Felipe or Myk - Could you look at this?
Whiteboard: [marketplace-beta?]
Severity: normal → critical
No longer blocks: 746229
Would be nice to know how many apps this effects. Leaving it as a blocker for now, but since there is a way to navigate the window manually I'm saying a "soft" blocker.
Keywords: qawanted
Investigation needed on the following applications: - Backpack - Basecamp - Campfire - Highrise - Ta-Da List - Lord of Ultima - Soundcloud - Times Crossword - Sky Guide
Changing the browser type to content-primary doesn't prevent scrolling in an app I'm using to test. So maybe the scrolling problem is app-specific. Mardak: how can I install your app? I went to http://ed.agadak.net/app/, and it wasn't clear how to install the app from there.
The manifest is at http://ed.agadak.net/manifest.webapp, and I've just been installing it through the web console in Firefox: navigator.mozApps.install("http://ed.agadak.net/manifest.webapp") There's various links on the page where you can navigate away, e.g., to youtube, and the page doesn't have scrollbars. But even without navigation, the marketplace app loses its scrollbars for me on the initial load. navigator.mozApps.install("http://marketplace-dev.allizom.org/manifest.webapp")
Blocks: 737571
Keywords: qawanted
Keywords: qawanted
Based on testing so far, i haven't seen this bug occur often involving the "same" domain. Usually so far I've seen a higher likelihood when it's opening a pop-up or window on a different domain. I don't think this is a marketplace beta blocker.
Keywords: qawanted
Whiteboard: [marketplace-beta?] → [marketplace-beta-]
Depends on: 732631
Ed - Is this fixed as a result of the bug dependency?
Assignee: nobody → edilee
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified on windows 7 64-bit and OS X 10.6.8.
Status: RESOLVED → VERIFIED
No longer blocks: 737571
Component: Desktop Runtime → Webapp Runtime
Product: Web Apps → Firefox
Flags: in-moztrap?(jsmith)
Flags: in-moztrap?(jsmith) → in-moztrap+
QA Contact: desktop-runtime → jsmith
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: