Opt: bp-bdbe2955-d9ce-487c-a72e-d0a0a2120419

Needs moar EnsureCurrentSurface. phone

On Windows 7: bp-72e70eb8-0995-401d-b377-406672120419

Thanks Jesse!

Comment on attachment 616774 [details] [diff] [review] Check for context allocation failure before returning inverse transform Review of attachment 616774 [details] [diff] [review]: ----------------------------------------------------------------- This needs to be fixed in nsCanvasRenderingContext2DAzure as well - otherwise we'll a) have this bug on some systems but not others and b) make crashtest go orange.

Well, OK, but in the port to azure canvas many/most of the EnsureCurrentSurface()-style checks were lost. This is putting ones finger in dike. Is there a bug on file for restoring them? Are we fuzzing azure canvas?

We are fuzzing azure canvas, but only on the (OS version, hardware) combinations in the build pool. The fuzzer randomizes gfx.canvas.azure.enabled so both azure and non-azure canvas are tested on as many platforms as possible.

OK. There are many azure-canvas interfaces that don't check for a valid surface whereas the same cairo-canvas interface does. (I assumed the checks weren't needed for azure-canvas.) Apparently we have a dearth of tests for those cases, and perhaps our fuzzer is getting unlucky?

fwiw, crash automation reproduced this on all three branches: Beta/12, Aurora/13, Nightly/14 and all 3 platforms.

Was cleaning mq house and came back across this. This version puts a few more fingers in the azure context dike.

Comment on attachment 631615 [details] [diff] [review] Check for context allocation failure before returning inverse transform, v2 Review of attachment 631615 [details] [diff] [review]: ----------------------------------------------------------------- Well, not azure content so much as azure canvas, but hooray. And thanks for fixing both implementations!