Closed
Bug 746848
Opened 13 years ago
Closed 13 years ago
Create pref for webapps installer dry-run
Categories
(Firefox Graveyard :: Web Apps, defect)
Firefox Graveyard
Web Apps
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 14
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
(Whiteboard: [qa!])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
This would be very helpful during tests of other parts of the api (bug 741549) as to not worry about waiting for the actual installation to happen, and possible garbage left in the slave in case a test fails and does not do proper clean-up.
Attachment #616408 -
Flags: review?(gavin.sharp)
|
Assignee | |
Comment 1•13 years ago
|
||
(missed closed paren in previous patch)
Attachment #616408 -
Attachment is obsolete: true
Attachment #616408 -
Flags: review?(gavin.sharp)
Attachment #616412 -
Flags: review?(gavin.sharp)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 616412 [details] [diff] [review]
Patch v2
nit: I kind of prefer just a getBoolPref call in a try/catch, since it's a little easier to read. Alternatively, use a local variable for the pref name so you can re-wrap the if statement onto only two lines.
Attachment #616412 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
|
||
Comment 4•13 years ago
|
||
Looks like an internal code change. Is there anything from an end-user perspective I can verify here?
|
||
Comment 5•13 years ago
|
||
You can set the pref to confirm that the app doesn't get installed.
|
|
||
Updated•13 years ago
|
Whiteboard: [qa+]
|
|
||
Comment 6•13 years ago
|
||
Verified on Win 7 64-bit on Nightly.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
|
|
||
Updated•12 years ago
|
Flags: in-moztrap-
|
|
||
Updated•12 years ago
|
QA Contact: jsmith
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•