Closed
Bug 746913
Opened 13 years ago
Closed 13 years ago
Plugins NativeRenderer X/qt/gtk includes defines cleanup
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla14
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
While porting Gecko to FB/PureX11 Honk port, I found one place which could be cleaned up and used for Honk port too without additional HONK ifdefs.
Attachment #616493 -
Flags: review?(karlt)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 616493 [details] [diff] [review]
Cleanup a bit X/Qt/Gtk nativeRenderer defines
> #ifdef MOZ_WIDGET_GTK2
> // This is the visual used by the widgets, 24-bit if available.
> GdkVisual* gdkVisual = gdk_rgb_get_visual();
> Visual* visual = gdk_x11_visual_get_xvisual(gdkVisual);
> Screen* screen =
> gdk_x11_screen_get_xscreen(gdk_visual_get_screen(gdkVisual));
> #endif
>-#ifdef MOZ_WIDGET_QT
>+#ifdef MOZ_X11
> Display* dpy = mozilla::DefaultXDisplay();
> Screen* screen = DefaultScreenOfDisplay(dpy);
> Visual* visual = DefaultVisualOfScreen(screen);
> #endif
This is all within a MOZ_X11 test, so I assume you just want an #else so that these are always defined only once.
Attachment #616493 -
Flags: review?(karlt) → review-
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → romaxa
Attachment #616493 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #616723 -
Flags: review?(karlt)
|
|
||
Updated•13 years ago
|
Attachment #616723 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•