Closed Bug 747338 Opened 13 years ago Closed 11 years ago

Set last-accessed timestamp when deselecting tabs rather than when selecting them

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 30

People

(Reporter: ttaubert, Assigned: dao)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

patch
(deleted), patch
ttaubert
: review+
Details | Diff | Splinter Review
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
For bug 675539 we need to know when a tab was last selected (or visible). Not sure if we need a setter for this? If session store is going to store this value (like in bug 739866) we might need to do that.
Attachment #616926 - Flags: review?(paul)
Comment on attachment 616926 [details] [diff] [review] patch v1 Having both lastAccessed and lastSelected with different meanings is confusing. If the former isn't what we need, we should fix that.
Attachment #616926 - Flags: review?(paul) → review-
(In reply to Dão Gottwald [:dao] from comment #1) > Having both lastAccessed and lastSelected with different meanings is > confusing. If the former isn't what we need, we should fix that. The former isn't what *I* need, but I agree that both are very (or too) similar. Not sure if bug 586067 could use lastSelected, too.
(In reply to Tim Taubert [:ttaubert] from comment #2) > Not sure if bug 586067 could use lastSelected, too. Yes. The point is to sort tabs in most-recently-used order.
Blocks: 739866
Summary: Store last selected timestamp → Set last-accessed timestamp when deselecting tabs rather than when selecting them
“Set last-accessed timestamp when deselecting tabs rather than when selecting them” I would rather say : both. In case of crash, it's good to know that the current tab was accessed. The current tab had been selected, but not yet deselected.
Blocks: 735868
Assignee: ttaubert → nobody
Status: ASSIGNED → NEW
So the only reason this didn't land is because a minor naming concern? Can we change to lastVisible and land?
Blocks: fxdesktopbacklog
Whiteboard: p=0
Assignee: nobody → dao
Attached patch patch (deleted) — — Splinter Review
Attachment #616926 - Attachment is obsolete: true
Attachment #8371390 - Flags: review?(ttaubert)
Comment on attachment 8371390 [details] [diff] [review] patch Review of attachment 8371390 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8371390 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/52f33b9a2208
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
No longer blocks: fxdesktopbacklog
Whiteboard: p=0
wooo, thanks y'all
Whiteboard: [qa-]
Comment on attachment 8371390 [details] [diff] [review] patch Review of attachment 8371390 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/tabbrowser.xml @@ +4720,5 @@ > </property> > > + <property name="lastAccessed"> > + <getter> > + return this.selected ? Date.now() : this._lastAccessed; Seems problematic in preview mode. We may set the time stamp on selected tab to Infinity.
Depends on: 980231
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: