Closed Bug 747442 Opened 13 years ago Closed 13 years ago

Only unlock orientation if the received mozfullscreenchange is for fullscreen being disabled

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14
Tracking Status
firefox14 - fixed

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Attached patch Patch v1 (deleted) — Splinter Review
It happens that if you do something like: addEventListener("mozfullscreenchange", function() { screen.mozLockOrientation("landscape"); }); The orientation will be changed to "landscape-foo" then back to the previous orientation is that when lock() is called, we add an event listener listening to the 'mozfullscreenchange' event which - and I had no idea that was the case before - is called immediately. The handler of that event is unlocking the screen so basically the lock() becomes some kind of a no-op.
Attachment #617024 - Flags: review?(bugs)
We should fix that for Gecko 14 because it could be quite an annoying bug for that new experimental feature (which comes with Gecko 14).
Comment on attachment 617024 [details] [diff] [review] Patch v1 Can we get a a testcase for this?
Attachment #617024 - Flags: review?(bugs) → review+
Attachment #617024 - Flags: approval-mozilla-central?
(In reply to Olli Pettay [:smaug] from comment #2) > Comment on attachment 617024 [details] [diff] [review] > Patch v1 > > Can we get a a testcase for this? We actually don't have tests for that. That would require writing Android tests (this is no fun) and screen orientation is using hardware sensors so even if we could test a few things it might limit us and generate random oranges. I was planning to dig into this later actually.
Attachment #617024 - Flags: approval-mozilla-central? → approval-mozilla-central+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: