While working on Bug 701432 I noticed several problems with the Windows 7 Jumplist. > +++ b/suite/modules/WindowsJumpLists.jsm > - let shortcut = this._getHandlerAppItem(title, title, aResult.uri, 1); We blindly copied this from Firefox. In firefox the second icon resource is document.ico, In SeaMonkey, however, it's the Mailbiff icon (newmail.ico). > + let shortcut = this._getHandlerAppItem(title, title, aResult.uri, 2); This patch adds a third icon resource to SeaMonkey.exe using html-file.ico which is the closest I can find to the Firefox document.ico and switches the WindowsJumpLists.jsm to use that instead. Also a drive by patch to remove bits of splash.rc that were there to support MOZ_STATIC_BUILD which was removed in Bug 684155 (Remove MOZ_STATIC_BUILD).

Bah, I can't believe I never (attentively) noticed this. Thanks Ratty (bug + fix)!

Comment on attachment 617331 [details] [diff] [review] Patch v1.0 Proposed fix. I forgot to add that you need to delete the Windows 7 icon cache and rebuild it before you can see any changes. This drove me crazy for a while wondering why my patch wasn't working, dammit :P (and explains why I was never able to devise a consistent STR to test my patch in Bug 701432).

Comment on attachment 617331 [details] [diff] [review] Patch v1.0 Proposed fix. > cp $(srcdir)/icons/windows/seamonkey.ico $(DIST)/branding/seamonkey.ico >+ cp $(srcdir)/icons/windows/html-file.ico $(DIST)/branding/html-file.ico > cp $(srcdir)/package/windows/branding.nsi $(DIST)/branding/branding.nsi > cp $(srcdir)/package/windows/wizHeader.bmp $(DIST)/branding/wizHeader.bmp > cp $(srcdir)/package/windows/wizHeaderRTL.bmp $(DIST)/branding/wizHeaderRTL.bmp > cp $(srcdir)/package/windows/wizWatermark.bmp $(DIST)/branding/wizWatermark.bmp [I wonder why this uses separate cp commands...] >- // We don't want source redirects for these queries. >- options.redirectsMode = Ci.nsINavHistoryQueryOptions.REDIRECTS_MODE_TARGET; Is this change copied from somewhere? r=me if it is.

(In reply to Philip Chee from comment #3) > I forgot to add that you need to delete the Windows 7 icon cache and rebuild > it before you can see any changes. Ah OK, then no matter what we do here, users need to take action. Setting relnote keyword. I guess we want this fixed on branches, too? (Don't bother requesting comm-beta approval right now; we won't have another beta before the uplift.)

>>- // We don't want source redirects for these queries. >>- options.redirectsMode = Ci.nsINavHistoryQueryOptions.REDIRECTS_MODE_TARGET; > Is this change copied from somewhere? r=me if it is. Urgh. Forgot to say that I kept getting this error when testing my patch: > Error: Cannot modify properties of a WrappedNative = NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN So I ported [Bug 737841 - Part 3: remove no more useful redirectsMode query option] to kill this error message. > I guess we want this fixed on branches, too? I don't think so, this is purely a cosmetic issue. security-- and stability--.

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/2cbb85b289f5 Commit comment: Bug 747774 The Windows 7 Jumplist is using the mailbiff icon, should use html-file.ico instead r=Neil. Also ports: Bug 684155 (Remove MOZ_STATIC_BUILD) Bug 737841 Part 3 (remove no more useful redirectsMode query option)