Closed
Bug 747872
Opened 13 years ago
Closed 13 years ago
Windows constants for js-ctypes (Chrome Workers)
Categories
(Core :: js-ctypes, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Companion for bug 739740, but for Windows constants, in particular Windows error values.
|
Assignee | |
Updated•13 years ago
|
Attachment #617442 -
Flags: review?(khuey)
Comment on attachment 617442 [details] [diff] [review]
Exporting Windows constants to JS
Review of attachment 617442 [details] [diff] [review]:
-----------------------------------------------------------------
This looks mostly fine, but I'd like to look at it again after you fix the other patch.
::: dom/system/OSFileConstants.cpp
@@ +10,5 @@
> #include "unistd.h"
> #endif // defined(XP_UNIX)
>
> +#if defined(XP_WIN)
> +#include "windows.h"
<windows.h> is the typical style.
Attachment #617442 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → dteller
Attachment #617442 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #618201 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•13 years ago
|
Summary: Windows constants for js-ctypes → Windows constants for js-ctypes (Chrome Workers)
|
|
Assignee | |
Updated•13 years ago
|
OS: Mac OS X → Windows XP
Hardware: x86 → All
Attachment #618201 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #618201 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Severity: normal → enhancement
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
|
|
||
Comment 5•13 years ago
|
||
http://mozillamemes.tumblr.com/post/21637966463/yes-i-have-a-condition-that-forces-me-to-insert
...and backed out for Win64 bustage (so far, anyway).
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf8b1f792ce
e:/builds/moz2_slave/m-in-w64/build/dom/system/OSFileConstants.cpp(220) : error C2065: 'INVALID_FILE_HANDLE' : undeclared identifier
Target Milestone: mozilla15 → ---
|
|
Assignee | |
Comment 6•13 years ago
|
||
Ok Yoric, take a breath, stop using three distinct local repositories, concentrate and stop uploading **** to the nice sheriffs.
Sorry, Ryan.
Attachment #622328 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 7•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla15
|
||
Comment 8•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•