Closed
Bug 748238
Opened 13 years ago
Closed 12 years ago
HTMLMeterElement should not be form controls
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: mounir, Assigned: mounir)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
mounir
:
checkin+
|
Details | Diff | Splinter Review |
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
|
Assignee | |
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
|
Assignee | |
Comment 2•13 years ago
|
||
Kyle, bug 686913 is about to be fixed and will take into account progress elements only so this is the meter part of it.
Status: REOPENED → NEW
|
|
Assignee | |
Updated•13 years ago
|
Keywords: dev-doc-needed
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Comment on attachment 630559 [details] [diff] [review]
Patch
Doesn't this make the meter non-labelable? Is that desired?
|
|
Assignee | |
Comment 5•12 years ago
|
||
Oh... The specs tricked me. Before (and that's how our code behave) only form controls were able to be labeled but since <progress> and <meter> are not form controls, Hixie changed the specs to allow any element to be labeled... I was assuming that given those elements were no longer form controls they were not labelable.
Patches will come.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #630559 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 6•12 years ago
|
||
That should fix it, using bug 762434.
BTW, I could have IsLabelable() defined in each element that is labelable with simply |return true;|. I just kept the nsIFormControl logic here so I did the same kind of thing for meter and progress. If you think having IsLabelable defined for each element would be better, I can do that.
Attachment #630559 -
Attachment is obsolete: true
Attachment #630921 -
Flags: review?(bzbarsky)
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 630921 [details] [diff] [review]
Patch v2
r=me
Attachment #630921 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•12 years ago
|
Flags: in-testsuite+
Target Milestone: --- → mozilla16
|
|
Assignee | |
Updated•12 years ago
|
Attachment #630921 -
Flags: checkin+
|
||
Comment 8•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•