Closed Bug 748240 Opened 13 years ago Closed 13 years ago

"view-source:" doesn't load HTML from AppCache

Categories

(Core :: Networking: Cache, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: timdream, Assigned: mayhemer)

References

Details

Attachments

(1 file)

Step to reproduce: 1. Go to a AppCache enabled website, make sure it's cached 2. Verified it is AppCache'd by checking about:cache?device=offline 3. Delete the HTTP cache (Preference -> Advanced -> Network -> Cached Web Content -> Clear Now) 4. Go offline (File -> Work Offline) 5. Go back to the website, it should load from AppCache 6. View source (cmd+U) Expected result: * view the source code Actual result: * Problem loading page == It's very tricky to reproduce the behavior in Firefox, but in B2G Gaia we test our apps by inserting offline AppCache directly into the profile with a fictitious hostname, that makes the behavior easy to surface (with the view source hardware key from in our dev preview phone) Is it possible to make view-source to access not only HTTP cache but also AppCache?
Component: Networking: Cache → View Source
Product: Core → Toolkit
QA Contact: networking.cache → view.source
No, this was in the right place. Necko is what's not hitting the appcache here. The toolkit code is just using the APIs core exposes for this stuff.
Component: View Source → Networking: Cache
Product: Toolkit → Core
QA Contact: view.source → networking.cache
(In reply to Boris Zbarsky (:bz) from comment #1) > No, this was in the right place. Necko is what's not hitting the appcache > here. The toolkit code is just using the APIs core exposes for this stuff. Oh thanks.
I'll look at this. I suspect this may be complicated, though...
Assignee: nobody → honzab.moz
Attached patch v1 (deleted) — Splinter Review
It was damn easy! :) Just let nsViewSourceChannel implement and forward nsIApplicatonCacheChannel.
Attachment #623113 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Attachment #623113 - Flags: review?(bzbarsky) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Depends on: 754588
This patch may have triggered a new intermittent leak in mochitests (bug 754588). Any thoughts on whether or how that might be related?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: