This will be useful in the fix for bug 722868.

Gavin: ping

Gavin: review ping!

Comment on attachment 618141 [details] [diff] [review] Patch (v1) Dave, would you mind reviewing this, or forwarding it to the right person if you're not that person? Thanks!

What are the changes to viewsource.js for? Is there some other patch that uses them?

See patches in bug 722868.

(In reply to Josh Matthews [:jdm] from comment #6) > See patches in bug 722868. Which one in particular? None of them use the new gFromPrivateWindow variable that this patch creates.

(In reply to Dave Townsend (:Mossop) from comment #7) > (In reply to Josh Matthews [:jdm] from comment #6) > > See patches in bug 722868. > > Which one in particular? None of them use the new gFromPrivateWindow > variable that this patch creates. gFromPrivateWindow is meant to make this possible to test, see the changes to browser/components/privatebrowsing/test/browser/browser_privatebrowsing_viewsource.js in this patch.

(In reply to Ehsan Akhgari [:ehsan] from comment #8) > (In reply to Dave Townsend (:Mossop) from comment #7) > > (In reply to Josh Matthews [:jdm] from comment #6) > > > See patches in bug 722868. > > > > Which one in particular? None of them use the new gFromPrivateWindow > > variable that this patch creates. > > gFromPrivateWindow is meant to make this possible to test, see the changes > to > browser/components/privatebrowsing/test/browser/ > browser_privatebrowsing_viewsource.js in this patch. Ok, but what is the point? All the patches I see are working to add this extra argument to the viewsource window. The test tests whether that extra argument got passed correctly (not sure why it doesn't just check window.arguments though). I haven't yet seen anything that uses that extra argument at all though, what am I missing?

Ah hmm, you're right. I don't remember what changes in bug 722868, but the latest patches which I landed no longer need this. So -> INVALID!